Title: [282041] trunk/LayoutTests
- Revision
- 282041
- Author
- cdu...@apple.com
- Date
- 2021-09-03 19:58:54 -0700 (Fri, 03 Sep 2021)
Log Message
[iOS] Regression(r282025) fast/forms/ios/remove-and-add-view-during-focus.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=229908
Reviewed by Wenson Hsieh.
The test is calling window.open() and it was causing a sync IPC to the UIProcess and a call
to uiController.willCreateNewPageCallback. However, because the test wasn't calling
`testRunner.setCanOpenWindows()`, it wasn't actually opening a popup.
Now that tests can open popups by default (since r282025), the popup actually opens and
its view becomes fist responder, which is confusing the test. To address the issue,
close the window as soon as it opens.
* fast/forms/ios/remove-and-add-view-during-focus.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (282040 => 282041)
--- trunk/LayoutTests/ChangeLog 2021-09-04 00:32:37 UTC (rev 282040)
+++ trunk/LayoutTests/ChangeLog 2021-09-04 02:58:54 UTC (rev 282041)
@@ -1,3 +1,20 @@
+2021-09-03 Chris Dumez <cdu...@apple.com>
+
+ [iOS] Regression(r282025) fast/forms/ios/remove-and-add-view-during-focus.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=229908
+
+ Reviewed by Wenson Hsieh.
+
+ The test is calling window.open() and it was causing a sync IPC to the UIProcess and a call
+ to uiController.willCreateNewPageCallback. However, because the test wasn't calling
+ `testRunner.setCanOpenWindows()`, it wasn't actually opening a popup.
+
+ Now that tests can open popups by default (since r282025), the popup actually opens and
+ its view becomes fist responder, which is confusing the test. To address the issue,
+ close the window as soon as it opens.
+
+ * fast/forms/ios/remove-and-add-view-during-focus.html:
+
2021-09-03 Robert Jenner <jen...@apple.com>
[Monterey Wk2 Debug] fast/history/visited-href-mutation.html is a flaky image failure
Modified: trunk/LayoutTests/fast/forms/ios/remove-and-add-view-during-focus.html (282040 => 282041)
--- trunk/LayoutTests/fast/forms/ios/remove-and-add-view-during-focus.html 2021-09-04 00:32:37 UTC (rev 282040)
+++ trunk/LayoutTests/fast/forms/ios/remove-and-add-view-during-focus.html 2021-09-04 02:58:54 UTC (rev 282041)
@@ -37,7 +37,10 @@
});
}
- createNewPageInput.addEventListener("focus", () => open("about:blank"), { "once" : true });
+ createNewPageInput.addEventListener("focus", () => {
+ w = open("about:blank");
+ w.close();
+ }, { "once" : true });
addEventListener("load", async () => {
description("This test verifies that unparenting, reparenting and then making the web view first responder while immediately after focusing an input field does not either cause a crash, or a hang when subsequently attempting to interact with the page. To test manually, tap the top field, dismiss the keyboard, and then tap the bottom field. The test passes if the UI process does not crash or hang.");
@@ -57,4 +60,4 @@
finishJSTest();
});
</script>
-</html>
\ No newline at end of file
+</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
