[webkit-changes] [282109] trunk/Source/WebKit

Tue, 07 Sep 2021 15:13:53 -0700

Title: [282109] trunk/Source/WebKit
Revision
282109
Author
[email protected]
Date
2021-09-07 15:13:17 -0700 (Tue, 07 Sep 2021)

Log Message

Simplify PrivateClickMeasurementManager interface
https://bugs.webkit.org/show_bug.cgi?id=230014

Reviewed by John Wilander.

ResourceRequest serialization is excessive and complicated.
Let's just serialize the parts we need instead.

* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::handlePrivateClickMeasurementConversion):
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClient.h:
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::handleAttribution):
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (282108 => 282109)


--- trunk/Source/WebKit/ChangeLog	2021-09-07 22:04:55 UTC (rev 282108)
+++ trunk/Source/WebKit/ChangeLog	2021-09-07 22:13:17 UTC (rev 282109)
@@ -1,3 +1,20 @@
+2021-09-07  Alex Christensen  <[email protected]>
+
+        Simplify PrivateClickMeasurementManager interface
+        https://bugs.webkit.org/show_bug.cgi?id=230014
+
+        Reviewed by John Wilander.
+
+        ResourceRequest serialization is excessive and complicated.
+        Let's just serialize the parts we need instead.
+
+        * NetworkProcess/NetworkSession.cpp:
+        (WebKit::NetworkSession::handlePrivateClickMeasurementConversion):
+        * NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClient.h:
+        * NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp:
+        (WebKit::PrivateClickMeasurementManager::handleAttribution):
+        * NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h:
+
 2021-09-07  Chris Dumez  <[email protected]>
 
         Implement origin partitioning (top-origin/frame-origin) for BroadcastChannel

Modified: trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp (282108 => 282109)


--- trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp	2021-09-07 22:04:55 UTC (rev 282108)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp	2021-09-07 22:13:17 UTC (rev 282109)
@@ -316,7 +316,7 @@
 
 void NetworkSession::handlePrivateClickMeasurementConversion(PrivateClickMeasurement::AttributionTriggerData&& attributionTriggerData, const URL& requestURL, const WebCore::ResourceRequest& redirectRequest)
 {
-    privateClickMeasurement().handleAttribution(WTFMove(attributionTriggerData), requestURL, redirectRequest);
+    privateClickMeasurement().handleAttribution(WTFMove(attributionTriggerData), requestURL, RegistrableDomain(redirectRequest.url()), redirectRequest.firstPartyForCookies());
 }
 
 void NetworkSession::dumpPrivateClickMeasurement(CompletionHandler<void(String)>&& completionHandler)

Modified: trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp (282108 => 282109)


--- trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp	2021-09-07 22:04:55 UTC (rev 282108)
+++ trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp	2021-09-07 22:13:17 UTC (rev 282109)
@@ -230,14 +230,11 @@
     store().insertPrivateClickMeasurement(WTFMove(measurement), type);
 }
 
-void PrivateClickMeasurementManager::handleAttribution(AttributionTriggerData&& attributionTriggerData, const URL& requestURL, const WebCore::ResourceRequest& redirectRequest)
+void PrivateClickMeasurementManager::handleAttribution(AttributionTriggerData&& attributionTriggerData, const URL& requestURL, WebCore::RegistrableDomain&& redirectDomain, const URL& firstPartyURL)
 {
     if (!featureEnabled())
         return;
 
-    RegistrableDomain redirectDomain { redirectRequest.url() };
-    auto& firstPartyURL = redirectRequest.firstPartyForCookies();
-
     if (!redirectDomain.matches(requestURL)) {
         m_client->broadcastConsoleMessage(MessageLevel::Warning, "[Private Click Measurement] Triggering event was not accepted because the HTTP redirect was not same-site."_s);
         return;

Modified: trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h (282108 => 282109)


--- trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h	2021-09-07 22:04:55 UTC (rev 282108)
+++ trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h	2021-09-07 22:13:17 UTC (rev 282109)
@@ -58,7 +58,7 @@
     ~PrivateClickMeasurementManager();
 
     void storeUnattributed(PrivateClickMeasurement&&);
-    void handleAttribution(AttributionTriggerData&&, const URL& requestURL, const WebCore::ResourceRequest& redirectRequest);
+    void handleAttribution(AttributionTriggerData&&, const URL& requestURL, WebCore::RegistrableDomain&& redirectDomain, const URL& firstPartyURL);
     void clear(CompletionHandler<void()>&&);
     void clearForRegistrableDomain(const RegistrableDomain&, CompletionHandler<void()>&&);
     void migratePrivateClickMeasurementFromLegacyStorage(PrivateClickMeasurement&&, PrivateClickMeasurementAttributionType);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to