Title: [282128] trunk/Tools
- Revision
- 282128
- Author
- hironori.fu...@sony.com
- Date
- 2021-09-07 21:57:37 -0700 (Tue, 07 Sep 2021)
Log Message
[Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
https://bugs.webkit.org/show_bug.cgi?id=229927
Reviewed by Don Olmstead.
TestWebKitAPI::Util::isKeyDown was not implemented
* TestWebKitAPI/CMakeLists.txt: Added Tests/WebKit/DidNotHandleKeyDown.cpp.
* TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp: GTK and WPE ports fail the test. Skip it.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Implemented.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (282127 => 282128)
--- trunk/Tools/ChangeLog 2021-09-08 03:44:16 UTC (rev 282127)
+++ trunk/Tools/ChangeLog 2021-09-08 04:57:37 UTC (rev 282128)
@@ -1,5 +1,19 @@
2021-09-07 Fujii Hironori <hironori.fu...@sony.com>
+ [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
+ https://bugs.webkit.org/show_bug.cgi?id=229927
+
+ Reviewed by Don Olmstead.
+
+ TestWebKitAPI::Util::isKeyDown was not implemented
+
+ * TestWebKitAPI/CMakeLists.txt: Added Tests/WebKit/DidNotHandleKeyDown.cpp.
+ * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp: GTK and WPE ports fail the test. Skip it.
+ * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
+ (TestWebKitAPI::Util::isKeyDown): Implemented.
+
+2021-09-07 Fujii Hironori <hironori.fu...@sony.com>
+
[Win] PlatformWebView::simulateSpacebarKeyPress sends wrong scan code for the space key and Alt key
https://bugs.webkit.org/show_bug.cgi?id=229928
Modified: trunk/Tools/TestWebKitAPI/CMakeLists.txt (282127 => 282128)
--- trunk/Tools/TestWebKitAPI/CMakeLists.txt 2021-09-08 03:44:16 UTC (rev 282127)
+++ trunk/Tools/TestWebKitAPI/CMakeLists.txt 2021-09-08 04:57:37 UTC (rev 282128)
@@ -253,6 +253,7 @@
Tests/WebKit/CanHandleRequest.cpp
Tests/WebKit/DOMWindowExtensionBasic.cpp
Tests/WebKit/DOMWindowExtensionNoCache.cpp
+ Tests/WebKit/DidNotHandleKeyDown.cpp
Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp
Tests/WebKit/DownloadDecideDestinationCrash.cpp
Tests/WebKit/EnumerateMediaDevices.cpp
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp (282127 => 282128)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp 2021-09-08 03:44:16 UTC (rev 282127)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp 2021-09-08 04:57:37 UTC (rev 282128)
@@ -26,6 +26,7 @@
#include "config.h"
#if WK_HAVE_C_SPI
+#if PLATFORM(COCOA) || PLATFORM(WIN)
#include "_javascript_Test.h"
#include "PlatformUtilities.h"
@@ -68,4 +69,5 @@
} // namespace TestWebKitAPI
+#endif // PLATFORM(COCOA) || PLATFORM(WIN)
#endif
Modified: trunk/Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp (282127 => 282128)
--- trunk/Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp 2021-09-08 03:44:16 UTC (rev 282127)
+++ trunk/Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp 2021-09-08 04:57:37 UTC (rev 282128)
@@ -62,8 +62,7 @@
bool isKeyDown(WKNativeEventPtr event)
{
- // FIXME
- return false;
+ return event->message == WM_KEYDOWN;
}
} // namespace Util
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
