Title: [282157] trunk/Source
Revision
282157
Author
[email protected]
Date
2021-09-08 10:30:57 -0700 (Wed, 08 Sep 2021)

Log Message

Remove unneeded call on startup of WebContent process
https://bugs.webkit.org/show_bug.cgi?id=230022
<rdar://problem/82838000>

Reviewed by Darin Adler.

Source/WebCore/PAL:

* pal/spi/cg/CoreGraphicsSPI.h:

Source/WebKit:

There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS,
since we already have asserted that there are no open connections at this point.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):

Modified Paths

Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (282156 => 282157)


--- trunk/Source/WebCore/PAL/ChangeLog	2021-09-08 17:24:18 UTC (rev 282156)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-09-08 17:30:57 UTC (rev 282157)
@@ -1,3 +1,13 @@
+2021-09-08  Per Arne  <[email protected]>
+
+        Remove unneeded call on startup of WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=230022
+        <rdar://problem/82838000>
+
+        Reviewed by Darin Adler.
+
+        * pal/spi/cg/CoreGraphicsSPI.h:
+
 2021-08-31  Myles C. Maxfield  <[email protected]>
 
         [Cocoa] Drawing system fallback fonts to canvas causes a crash

Modified: trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h (282156 => 282157)


--- trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h	2021-09-08 17:24:18 UTC (rev 282156)
+++ trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h	2021-09-08 17:30:57 UTC (rev 282157)
@@ -335,8 +335,6 @@
 
 bool CGDisplayUsesForceToGray(void);
 
-void CGSShutdownServerConnections(void);
-
 CGSConnectionID CGSMainConnectionID(void);
 CFArrayRef CGSHWCaptureWindowList(CGSConnectionID, CGSWindowIDList windowList, CGSWindowCount, CGSWindowCaptureOptions);
 CGError CGSSetConnectionProperty(CGSConnectionID, CGSConnectionID ownerCid, CFStringRef key, CFTypeRef value);

Modified: trunk/Source/WebKit/ChangeLog (282156 => 282157)


--- trunk/Source/WebKit/ChangeLog	2021-09-08 17:24:18 UTC (rev 282156)
+++ trunk/Source/WebKit/ChangeLog	2021-09-08 17:30:57 UTC (rev 282157)
@@ -1,3 +1,17 @@
+2021-09-08  Per Arne  <[email protected]>
+
+        Remove unneeded call on startup of WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=230022
+        <rdar://problem/82838000>
+
+        Reviewed by Darin Adler.
+
+        There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS,
+        since we already have asserted that there are no open connections at this point.
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeProcess):
+
 2021-09-08  Jean-Yves Avenard  <[email protected]>
 
         Safari TP 131 audio canPlayType() reports false negatives

Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (282156 => 282157)


--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-09-08 17:24:18 UTC (rev 282156)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-09-08 17:30:57 UTC (rev 282157)
@@ -632,8 +632,6 @@
     // This call will not succeed if there are open WindowServer connections at this point.
     auto retval = CGSSetDenyWindowServerConnections(true);
     RELEASE_ASSERT(retval == kCGErrorSuccess);
-    // Make sure that we close any WindowServer connections after checking in with Launch Services.
-    CGSShutdownServerConnections();
 
     SwitchingGPUClient::setSingleton(WebSwitchingGPUClient::singleton());
     MainThreadSharedTimer::shouldSetupPowerObserver() = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to