Title: [282194] trunk
- Revision
- 282194
- Author
- [email protected]
- Date
- 2021-09-08 23:56:55 -0700 (Wed, 08 Sep 2021)
Log Message
RTCPeerConnection.addIceCandidate takes an optional argument
https://bugs.webkit.org/show_bug.cgi?id=229962
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
* web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
* web-platform-tests/webrtc/idlharness.https.window-expected.txt:
Source/WebCore:
Covered by rebased test.
* Modules/mediastream/RTCPeerConnection.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282193 => 282194)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-09 06:49:35 UTC (rev 282193)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-09 06:56:55 UTC (rev 282194)
@@ -1,3 +1,13 @@
+2021-09-08 Youenn Fablet <[email protected]>
+
+ RTCPeerConnection.addIceCandidate takes an optional argument
+ https://bugs.webkit.org/show_bug.cgi?id=229962
+
+ Reviewed by Eric Carlson.
+
+ * web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
+ * web-platform-tests/webrtc/idlharness.https.window-expected.txt:
+
2021-09-08 Antti Koivisto <[email protected]>
[LFC][Integration] Hovering over link switches to legacy inline boxes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt (282193 => 282194)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt 2021-09-09 06:49:35 UTC (rev 282193)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt 2021-09-09 06:56:55 UTC (rev 282194)
@@ -6,7 +6,7 @@
FAIL createOffer must detect InvalidStateError synchronously when chain is empty (prerequisite) assert_equals: expected "InvalidStateError" but got "Error"
PASS createAnswer must detect InvalidStateError synchronously when chain is empty (prerequisite)
FAIL SLD(rollback) must detect InvalidStateError synchronously when chain is empty assert_equals: promise rejected on same task expected "rejected" but got "pending"
-FAIL addIceCandidate must detect InvalidStateError synchronously when chain is empty assert_equals: expected "InvalidStateError" but got "TypeError"
+FAIL addIceCandidate must detect InvalidStateError synchronously when chain is empty assert_equals: expected "InvalidStateError" but got "Error"
PASS replaceTrack must detect InvalidStateError synchronously when chain is empty and transceiver is stopped
PASS setParameters must detect InvalidStateError synchronously always when transceiver is stopped
FAIL pc.getStats must detect InvalidAccessError synchronously always assert_equals: expected "InvalidAccessError" but got "Error"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt (282193 => 282194)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt 2021-09-09 06:49:35 UTC (rev 282193)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt 2021-09-09 06:56:55 UTC (rev 282194)
@@ -32,7 +32,7 @@
PASS RTCPeerConnection interface: attribute remoteDescription
PASS RTCPeerConnection interface: attribute currentRemoteDescription
PASS RTCPeerConnection interface: attribute pendingRemoteDescription
-FAIL RTCPeerConnection interface: operation addIceCandidate(optional RTCIceCandidateInit) assert_equals: property has wrong .length expected 0 but got 1
+PASS RTCPeerConnection interface: operation addIceCandidate(optional RTCIceCandidateInit)
PASS RTCPeerConnection interface: attribute signalingState
PASS RTCPeerConnection interface: attribute iceGatheringState
PASS RTCPeerConnection interface: attribute iceConnectionState
@@ -53,7 +53,7 @@
PASS RTCPeerConnection interface: operation setLocalDescription(RTCLocalSessionDescriptionInit, VoidFunction, RTCPeerConnectionErrorCallback)
PASS RTCPeerConnection interface: operation createAnswer(RTCSessionDescriptionCallback, RTCPeerConnectionErrorCallback)
PASS RTCPeerConnection interface: operation setRemoteDescription(RTCSessionDescriptionInit, VoidFunction, RTCPeerConnectionErrorCallback)
-FAIL RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidateInit, VoidFunction, RTCPeerConnectionErrorCallback) assert_equals: property has wrong .length expected 0 but got 1
+PASS RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidateInit, VoidFunction, RTCPeerConnectionErrorCallback)
PASS RTCPeerConnection interface: operation generateCertificate(AlgorithmIdentifier)
PASS RTCPeerConnection interface: operation getSenders()
PASS RTCPeerConnection interface: operation getReceivers()
Modified: trunk/Source/WebCore/ChangeLog (282193 => 282194)
--- trunk/Source/WebCore/ChangeLog 2021-09-09 06:49:35 UTC (rev 282193)
+++ trunk/Source/WebCore/ChangeLog 2021-09-09 06:56:55 UTC (rev 282194)
@@ -1,5 +1,16 @@
2021-09-08 Youenn Fablet <[email protected]>
+ RTCPeerConnection.addIceCandidate takes an optional argument
+ https://bugs.webkit.org/show_bug.cgi?id=229962
+
+ Reviewed by Eric Carlson.
+
+ Covered by rebased test.
+
+ * Modules/mediastream/RTCPeerConnection.idl:
+
+2021-09-08 Youenn Fablet <[email protected]>
+
Add video metrics logging to LocalSampleBufferDisplayLayer
https://bugs.webkit.org/show_bug.cgi?id=229930
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (282193 => 282194)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2021-09-09 06:49:35 UTC (rev 282193)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2021-09-09 06:56:55 UTC (rev 282194)
@@ -93,7 +93,7 @@
readonly attribute RTCSessionDescription? currentRemoteDescription;
readonly attribute RTCSessionDescription? pendingRemoteDescription;
- Promise<undefined> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate);
+ Promise<undefined> addIceCandidate(optional (RTCIceCandidateInit or RTCIceCandidate) candidate);
readonly attribute RTCSignalingState signalingState;
readonly attribute RTCIceGatheringState iceGatheringState;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
