Title: [106497] trunk/Source/_javascript_Core
- Revision
- 106497
- Author
- [email protected]
- Date
- 2012-02-01 14:27:32 -0800 (Wed, 01 Feb 2012)
Log Message
DFG graph dump for GetScopedVar should show the correct prediction
https://bugs.webkit.org/show_bug.cgi?id=77530
Reviewed by Geoff Garen.
GetScopedVar has a heap prediction, not a variable prediction. But it does
have a variable. Hence we need to check for heap predictions before checking
for variable predictions.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106496 => 106497)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-01 22:15:45 UTC (rev 106496)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-01 22:27:32 UTC (rev 106497)
@@ -1,3 +1,17 @@
+2012-02-01 Filip Pizlo <[email protected]>
+
+ DFG graph dump for GetScopedVar should show the correct prediction
+ https://bugs.webkit.org/show_bug.cgi?id=77530
+
+ Reviewed by Geoff Garen.
+
+ GetScopedVar has a heap prediction, not a variable prediction. But it does
+ have a variable. Hence we need to check for heap predictions before checking
+ for variable predictions.
+
+ * dfg/DFGGraph.cpp:
+ (JSC::DFG::Graph::dump):
+
2012-02-01 Mark Hahnenberg <[email protected]>
Replace JSArray destructor with finalizer
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (106496 => 106497)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2012-02-01 22:15:45 UTC (rev 106496)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2012-02-01 22:27:32 UTC (rev 106497)
@@ -261,10 +261,10 @@
if (!skipped) {
if (node.hasVariableAccessData())
printf(" predicting %s, double ratio %lf%s", predictionToString(node.variableAccessData()->prediction()), node.variableAccessData()->doubleVoteRatio(), node.variableAccessData()->shouldUseDoubleFormat() ? ", forcing double" : "");
+ else if (node.hasHeapPrediction())
+ printf(" predicting %s", predictionToString(node.getHeapPrediction()));
else if (node.hasVarNumber())
printf(" predicting %s", predictionToString(getGlobalVarPrediction(node.varNumber())));
- else if (node.hasHeapPrediction())
- printf(" predicting %s", predictionToString(node.getHeapPrediction()));
}
printf("\n");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
