Title: [282237] trunk/Source/WebCore
- Revision
- 282237
- Author
- [email protected]
- Date
- 2021-09-09 13:05:16 -0700 (Thu, 09 Sep 2021)
Log Message
[Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black
https://bugs.webkit.org/show_bug.cgi?id=230077
Reviewed by Don Olmstead.
r282123 enabled HAVE_OS_DARK_MODE_SUPPORT for WinCairo. It uses
'-webkit-control-background' in the user-agent style sheet.
RenderThemeWin::systemColor always returned black for it. Because
WinCairo doesn't support dark mode yet, it is always light mode.
So, '-webkit-control-background' should be white at the moment.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemColor const): Return white for CSSValueWebkitControlBackground.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (282236 => 282237)
--- trunk/Source/WebCore/ChangeLog 2021-09-09 19:59:07 UTC (rev 282236)
+++ trunk/Source/WebCore/ChangeLog 2021-09-09 20:05:16 UTC (rev 282237)
@@ -1,3 +1,19 @@
+2021-09-09 Fujii Hironori <[email protected]>
+
+ [Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black
+ https://bugs.webkit.org/show_bug.cgi?id=230077
+
+ Reviewed by Don Olmstead.
+
+ r282123 enabled HAVE_OS_DARK_MODE_SUPPORT for WinCairo. It uses
+ '-webkit-control-background' in the user-agent style sheet.
+ RenderThemeWin::systemColor always returned black for it. Because
+ WinCairo doesn't support dark mode yet, it is always light mode.
+ So, '-webkit-control-background' should be white at the moment.
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::systemColor const): Return white for CSSValueWebkitControlBackground.
+
2021-09-09 Sihui Liu <[email protected]>
Unreviewed build fix for win after r282222.
Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (282236 => 282237)
--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2021-09-09 19:59:07 UTC (rev 282236)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2021-09-09 20:05:16 UTC (rev 282237)
@@ -1004,6 +1004,13 @@
Color RenderThemeWin::systemColor(CSSValueID cssValueId, OptionSet<StyleColor::Options> options) const
{
+#if HAVE(OS_DARK_MODE_SUPPORT)
+ switch (cssValueId) {
+ case CSSValueWebkitControlBackground:
+ // FIXME: Dark mode isn't supported yet. https://webkit.org/b/230032
+ return Color::white;
+ }
+#endif
int sysColorIndex = cssValueIdToSysColorIndex(cssValueId);
if (sysColorIndex == -1)
return RenderTheme::systemColor(cssValueId, options);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
