Diff
Modified: trunk/Source/WebKit/ChangeLog (282313 => 282314)
--- trunk/Source/WebKit/ChangeLog 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/ChangeLog 2021-09-12 00:32:08 UTC (rev 282314)
@@ -1,3 +1,27 @@
+2021-09-11 Wenson Hsieh <[email protected]>
+
+ Remove support for -[WKWebView _needsSiteSpecificViewportQuirks]
+ https://bugs.webkit.org/show_bug.cgi?id=230193
+
+ Reviewed by Tim Horton.
+
+ This SPI is no longer needed; for the brief moment it existed, it was only used to allow Safari's lowered bar
+ (which previously overlapped page content) to additionally apply obscured bottom insets on a handful of
+ webpages.
+
+ This method has no internal clients (including Safari).
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _needsSiteSpecificViewportQuirks]): Deleted.
+ * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::resetStateAfterProcessTermination):
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/WebPageProxy.messages.in:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::didCommitLoad):
+ * WebProcess/WebPage/WebPage.h:
+
2021-09-11 David Kilzer <[email protected]>
CFNotificationCenterAddObserver() should use weak observers
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (282313 => 282314)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-09-12 00:32:08 UTC (rev 282314)
@@ -2527,11 +2527,6 @@
return true;
}
-- (BOOL)_needsSiteSpecificViewportQuirks
-{
- return _page && _page->needsSiteSpecificViewportQuirks();
-}
-
- (pid_t)_webProcessIdentifier
{
if (![self _isValid])
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (282313 => 282314)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h 2021-09-12 00:32:08 UTC (rev 282314)
@@ -412,8 +412,6 @@
- (void)_suspendPage:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macos(12.0), ios(15.0));
- (void)_resumePage:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macos(12.0), ios(15.0));
-@property (nonatomic, readonly) BOOL _needsSiteSpecificViewportQuirks WK_API_AVAILABLE(macos(12.0), ios(15.0));
-
@end
#if TARGET_OS_IPHONE
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (282313 => 282314)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-09-12 00:32:08 UTC (rev 282314)
@@ -7730,8 +7730,6 @@
if (auto* automationSession = process().processPool().automationSession())
automationSession->terminate();
}
-
- m_needsSiteSpecificViewportQuirks = true;
}
void WebPageProxy::provisionalProcessDidTerminate()
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (282313 => 282314)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2021-09-12 00:32:08 UTC (rev 282314)
@@ -1971,9 +1971,6 @@
WKQuickLookPreviewController *quickLookPreviewController() const { return m_quickLookPreviewController.get(); }
#endif
- bool needsSiteSpecificViewportQuirks() const { return m_needsSiteSpecificViewportQuirks; }
- void setNeedsSiteSpecificViewportQuirks(bool value) { m_needsSiteSpecificViewportQuirks = value; }
-
#if PLATFORM(MAC)
bool isQuarantinedAndNotUserApproved(const String&);
#endif
@@ -3100,8 +3097,6 @@
RetainPtr<WKQuickLookPreviewController> m_quickLookPreviewController;
#endif
- bool m_needsSiteSpecificViewportQuirks { true };
-
WindowKind m_windowKind { WindowKind::Unparented };
};
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in (282313 => 282314)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in 2021-09-12 00:32:08 UTC (rev 282314)
@@ -414,8 +414,6 @@
ShowDataDetectorsUIForPositionInformation(struct WebKit::InteractionInformationAtPosition information)
#endif
- SetNeedsSiteSpecificViewportQuirks(bool value)
-
DidChangeInspectorFrontendCount(uint64_t count)
CreateInspectorTarget(String targetId, enum:uint8_t Inspector::InspectorTargetType type)
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (282313 => 282314)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-09-12 00:32:08 UTC (rev 282314)
@@ -6321,12 +6321,6 @@
if (!frame->isMainFrame())
return;
- bool needsSiteSpecificViewportQuirks = frame->coreFrame()->settings().needsSiteSpecificQuirks();
- if (m_needsSiteSpecificViewportQuirks != needsSiteSpecificViewportQuirks) {
- m_needsSiteSpecificViewportQuirks = needsSiteSpecificViewportQuirks;
- send(Messages::WebPageProxy::SetNeedsSiteSpecificViewportQuirks(needsSiteSpecificViewportQuirks));
- }
-
if (m_drawingArea)
m_drawingArea->sendEnterAcceleratedCompositingModeIfNeeded();
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (282313 => 282314)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2021-09-12 00:32:08 UTC (rev 282314)
@@ -2376,8 +2376,6 @@
#if ENABLE(APP_HIGHLIGHTS)
WebCore::HighlightVisibility m_appHighlightsVisible { WebCore::HighlightVisibility::Hidden };
#endif
-
- bool m_needsSiteSpecificViewportQuirks { true };
};
#if !PLATFORM(IOS_FAMILY)
