Title: [282333] trunk/Tools
- Revision
- 282333
- Author
- [email protected]
- Date
- 2021-09-13 10:06:20 -0700 (Mon, 13 Sep 2021)
Log Message
[TestWTF] Hash tests for denorm_min should be skipped if denorm is not supported.
https://bugs.webkit.org/show_bug.cgi?id=230177
Reviewed by Don Olmstead.
std::numeric_limits::denorm_min does not return a denormalized value
if denormal number is not supported. Test denorm_min only if
(has_denorm == denorm_present).
* TestWebKitAPI/Tests/WTF/Hasher.cpp:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (282332 => 282333)
--- trunk/Tools/ChangeLog 2021-09-13 17:01:14 UTC (rev 282332)
+++ trunk/Tools/ChangeLog 2021-09-13 17:06:20 UTC (rev 282333)
@@ -1,3 +1,17 @@
+2021-09-13 Yoshiaki Jitsukawa <[email protected]>
+
+ [TestWTF] Hash tests for denorm_min should be skipped if denorm is not supported.
+ https://bugs.webkit.org/show_bug.cgi?id=230177
+
+ Reviewed by Don Olmstead.
+
+ std::numeric_limits::denorm_min does not return a denormalized value
+ if denormal number is not supported. Test denorm_min only if
+ (has_denorm == denorm_present).
+
+ * TestWebKitAPI/Tests/WTF/Hasher.cpp:
+ (TestWebKitAPI::TEST):
+
2021-09-13 Aakash Jain <[email protected]>
Reduce EWS email notifications to Aakash
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp (282332 => 282333)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp 2021-09-13 17:01:14 UTC (rev 282332)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp 2021-09-13 17:06:20 UTC (rev 282333)
@@ -123,7 +123,8 @@
{
EXPECT_EQ(zero64BitHash, computeHash(0.0));
EXPECT_EQ(1264532604U, computeHash(-0.0)); // Note, not same as hash of 0.0.
- EXPECT_EQ(one64BitHash, computeHash(std::numeric_limits<double>::denorm_min()));
+ if (std::numeric_limits<double>::has_denorm == std::denorm_present)
+ EXPECT_EQ(one64BitHash, computeHash(std::numeric_limits<double>::denorm_min()));
EXPECT_EQ(2278399980U, computeHash(1.0));
EXPECT_EQ(3870689297U, computeHash(-1.0));
@@ -140,7 +141,8 @@
EXPECT_EQ(zero32BitHash, computeHash(0.0f));
EXPECT_EQ(2425683428U, computeHash(-0.0f)); // Note, not same as hash of 0.0f.
- EXPECT_EQ(one32BitHash, computeHash(std::numeric_limits<float>::denorm_min()));
+ if (std::numeric_limits<float>::has_denorm == std::denorm_present)
+ EXPECT_EQ(one32BitHash, computeHash(std::numeric_limits<float>::denorm_min()));
EXPECT_EQ(1081575966U, computeHash(1.0f));
EXPECT_EQ(3262093188U, computeHash(-1.0f));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
