Title: [282359] trunk
- Revision
- 282359
- Author
- [email protected]
- Date
- 2021-09-13 14:32:57 -0700 (Mon, 13 Sep 2021)
Log Message
transform-origin should not accept 4 lengths
https://bugs.webkit.org/show_bug.cgi?id=186965
transform-origin accepts 1, 2, or 3 values per the spec below.
https://drafts.csswg.org/css-transforms/#propdef-transform-origin
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt:
Source/WebCore:
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTransformOrigin):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282358 => 282359)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-13 21:20:16 UTC (rev 282358)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-13 21:32:57 UTC (rev 282359)
@@ -1,3 +1,15 @@
+2021-09-13 Joonghun Park <[email protected]>
+
+ transform-origin should not accept 4 lengths
+ https://bugs.webkit.org/show_bug.cgi?id=186965
+
+ transform-origin accepts 1, 2, or 3 values per the spec below.
+ https://drafts.csswg.org/css-transforms/#propdef-transform-origin
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt:
+
2021-09-13 Sam Sneddon <[email protected]>
Move ENABLE_RESOLUTION_MEDIA_QUERY to a runtime flag, start running tests again
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt (282358 => 282359)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt 2021-09-13 21:20:16 UTC (rev 282358)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt 2021-09-13 21:32:57 UTC (rev 282359)
@@ -1,7 +1,7 @@
PASS e.style['transform-origin'] = "1px 2px 3%" should not set the property value
PASS e.style['transform-origin'] = "1px 2px left" should not set the property value
-FAIL e.style['transform-origin'] = "1px 2px 3px 4px" should not set the property value assert_equals: expected "" but got "1px 2px 3px"
+PASS e.style['transform-origin'] = "1px 2px 3px 4px" should not set the property value
PASS e.style['transform-origin'] = "1px left" should not set the property value
PASS e.style['transform-origin'] = "top 1px" should not set the property value
PASS e.style['transform-origin'] = "right left" should not set the property value
Modified: trunk/Source/WebCore/ChangeLog (282358 => 282359)
--- trunk/Source/WebCore/ChangeLog 2021-09-13 21:20:16 UTC (rev 282358)
+++ trunk/Source/WebCore/ChangeLog 2021-09-13 21:32:57 UTC (rev 282359)
@@ -1,3 +1,16 @@
+2021-09-13 Joonghun Park <[email protected]>
+
+ transform-origin should not accept 4 lengths
+ https://bugs.webkit.org/show_bug.cgi?id=186965
+
+ transform-origin accepts 1, 2, or 3 values per the spec below.
+ https://drafts.csswg.org/css-transforms/#propdef-transform-origin
+
+ Reviewed by Simon Fraser.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::CSSPropertyParser::consumeTransformOrigin):
+
2021-09-13 Tyler Wilcock <[email protected]>
AX: Make PDFs loaded via <embed> accessible
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (282358 => 282359)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-09-13 21:20:16 UTC (rev 282358)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-09-13 21:32:57 UTC (rev 282359)
@@ -357,7 +357,7 @@
bool atEnd = m_range.atEnd();
auto resultZ = consumeLength(m_range, m_context.mode, ValueRange::All);
bool hasZ = resultZ;
- if (!hasZ && !atEnd)
+ if ((!hasZ && !atEnd) || !m_range.atEnd())
return false;
addProperty(CSSPropertyTransformOriginX, CSSPropertyTransformOrigin, WTFMove(resultXY->x), important);
addProperty(CSSPropertyTransformOriginY, CSSPropertyTransformOrigin, WTFMove(resultXY->y), important);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
