Title: [282380] trunk/Source/WebCore
Revision
282380
Author
[email protected]
Date
2021-09-14 00:18:22 -0700 (Tue, 14 Sep 2021)

Log Message

Fix bug in calc functions sin/cos/tan
https://bugs.webkit.org/show_bug.cgi?id=230133

Patch by Nikos Mouchtaris <[email protected]> on 2021-09-14
Reviewed by Myles Maxfield.

WPTs added in seperate patch: https://bugs.webkit.org/show_bug.cgi?id=230129.

* css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::simplifyNode):
Fix bug where sin,cos,tan functions are applied twice when root.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (282379 => 282380)


--- trunk/Source/WebCore/ChangeLog	2021-09-14 04:42:12 UTC (rev 282379)
+++ trunk/Source/WebCore/ChangeLog	2021-09-14 07:18:22 UTC (rev 282380)
@@ -1,3 +1,16 @@
+2021-09-14  Nikos Mouchtaris  <[email protected]>
+
+        Fix bug in calc functions sin/cos/tan
+        https://bugs.webkit.org/show_bug.cgi?id=230133
+
+        Reviewed by Myles Maxfield.
+
+        WPTs added in seperate patch: https://bugs.webkit.org/show_bug.cgi?id=230129.
+
+        * css/calc/CSSCalcOperationNode.cpp:
+        (WebCore::CSSCalcOperationNode::simplifyNode):
+        Fix bug where sin,cos,tan functions are applied twice when root.
+
 2021-09-13  Simon Fraser  <[email protected]>
 
         Fix computed style for transform-origin on SVG boxes

Modified: trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp (282379 => 282380)


--- trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp	2021-09-14 04:42:12 UTC (rev 282379)
+++ trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp	2021-09-14 07:18:22 UTC (rev 282380)
@@ -645,7 +645,7 @@
         if (calcOperationNode.isMinOrMaxNode())
             calcOperationNode.combineChildren();
         
-        if (calcOperationNode.isTrigNode())
+        if (calcOperationNode.isTrigNode() && depth)
             calcOperationNode.combineChildren();
         
         // If only one child remains, return the child (except at the root).
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to