Log Message
[JSC] Remove unnecessary exception checks in DFGOperations https://bugs.webkit.org/show_bug.cgi?id=230247
Patch by Xan Lopez <[email protected]> on 2021-09-14 Reviewed by Caio Araujo Neponoceno de Lima. JSValue::decode cannot throw an exception, remove a couple of unnecessary RETURN_IF_EXCEPTION() calls. * dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (282386 => 282387)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-14 13:19:06 UTC (rev 282386)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-14 13:49:12 UTC (rev 282387)
@@ -1,3 +1,16 @@
+2021-09-14 Xan Lopez <[email protected]>
+
+ [JSC] Remove unnecessary exception checks in DFGOperations
+ https://bugs.webkit.org/show_bug.cgi?id=230247
+
+ Reviewed by Caio Araujo Neponoceno de Lima.
+
+ JSValue::decode cannot throw an exception, remove a couple of
+ unnecessary RETURN_IF_EXCEPTION() calls.
+
+ * dfg/DFGOperations.cpp:
+ (JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+
2021-09-14 Xan López <[email protected]>
[JSC] ASSERT failed in stress/for-in-tests.js (32bit)
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (282386 => 282387)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2021-09-14 13:19:06 UTC (rev 282386)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2021-09-14 13:49:12 UTC (rev 282387)
@@ -2530,7 +2530,6 @@
auto scope = DECLARE_THROW_SCOPE(vm);
JSValue base = JSValue::decode(baseValue);
- RETURN_IF_EXCEPTION(scope, { });
if (modeNumber == JSPropertyNameEnumerator::IndexedMode && base.isObject())
RELEASE_AND_RETURN(scope, JSValue::encode(jsBoolean(jsCast<JSObject*>(base)->hasProperty(globalObject, index))));
@@ -2558,7 +2557,6 @@
auto scope = DECLARE_THROW_SCOPE(vm);
JSValue base = JSValue::decode(baseValue);
- RETURN_IF_EXCEPTION(scope, { });
if (modeNumber == JSPropertyNameEnumerator::IndexedMode && base.isObject())
RELEASE_AND_RETURN(scope, JSValue::encode(jsBoolean(jsCast<JSObject*>(base)->hasOwnProperty(globalObject, index))));
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
