Diff
Modified: trunk/LayoutTests/ChangeLog (282415 => 282416)
--- trunk/LayoutTests/ChangeLog 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/LayoutTests/ChangeLog 2021-09-14 22:25:25 UTC (rev 282416)
@@ -1,3 +1,15 @@
+2021-09-14 Ryan Haddad <[email protected]>
+
+ Unreviewed, reverting r282408.
+
+ Breaks internal builds.
+
+ Reverted changeset:
+
+ "Enable RTCRtpScriptTransform by default"
+ https://bugs.webkit.org/show_bug.cgi?id=230220
+ https://commits.webkit.org/r282408
+
2021-09-14 Myles C. Maxfield <[email protected]>
CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers
Modified: trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html (282415 => 282416)
--- trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html 2021-09-14 22:25:25 UTC (rev 282416)
@@ -9,7 +9,7 @@
<script>
promise_test(async (test) => {
if (window.internals)
- internals.settings.setWebRTCEncodedTransformEnabled(true);
+ internals.settings.setWebRTCInsertableStreamsEnabled(true);
const worker = new Worker('no-transform.js');
const data = "" new Promise(resolve => worker._onmessage_ = (event) => resolve(event.data));
@@ -18,7 +18,7 @@
promise_test(async (test) => {
if (window.internals)
- internals.settings.setWebRTCEncodedTransformEnabled(false);
+ internals.settings.setWebRTCInsertableStreamsEnabled(false);
const worker = new Worker('no-transform.js');
const data = "" new Promise(resolve => worker._onmessage_ = (event) => resolve(event.data));
Modified: trunk/Source/WTF/ChangeLog (282415 => 282416)
--- trunk/Source/WTF/ChangeLog 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WTF/ChangeLog 2021-09-14 22:25:25 UTC (rev 282416)
@@ -1,3 +1,15 @@
+2021-09-14 Ryan Haddad <[email protected]>
+
+ Unreviewed, reverting r282408.
+
+ Breaks internal builds.
+
+ Reverted changeset:
+
+ "Enable RTCRtpScriptTransform by default"
+ https://bugs.webkit.org/show_bug.cgi?id=230220
+ https://commits.webkit.org/r282408
+
2021-09-14 Myles C. Maxfield <[email protected]>
CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (282415 => 282416)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-14 22:25:25 UTC (rev 282416)
@@ -1392,19 +1392,6 @@
WebKit:
default: WebKit::defaultWebMParserEnabled()
-WebRTCEncodedTransformEnabled:
- type: bool
- condition: ENABLE(WEB_RTC)
- humanReadableName: "WebRTC Encoded Transform API"
- humanReadableDescription: "Enable WebRTC Encoded Transform API"
- defaultValue:
- WebKitLegacy:
- default: false
- WebKit:
- default: true
- WebCore:
- default: true
-
# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
WebRTCH264LowLatencyEncoderEnabled:
type: bool
@@ -1431,6 +1418,19 @@
WebKit:
default: false
+WebRTCInsertableStreamsEnabled:
+ type: bool
+ condition: ENABLE(WEB_RTC)
+ humanReadableName: "WebRTC Insertable Streams API"
+ humanReadableDescription: "Enable WebRTC Insertable Streams API"
+ defaultValue:
+ WebKitLegacy:
+ default: false
+ WebKit:
+ default: false
+ WebCore:
+ default: false
+
# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
WebRTCPlatformCodecsInGPUProcessEnabled:
type: bool
@@ -1465,19 +1465,6 @@
WebKit:
default: true
-WebRTCSFrameTransformEnabled:
- type: bool
- condition: ENABLE(WEB_RTC)
- humanReadableName: "WebRTC SFrame Transform API"
- humanReadableDescription: "Enable WebRTC SFrame Transform API"
- defaultValue:
- WebKitLegacy:
- default: false
- WebKit:
- default: false
- WebCore:
- default: false
-
WebRTCSocketsProxyingEnabled:
type: bool
humanReadableName: "WebRTC Sockets Proxying"
Modified: trunk/Source/WebCore/ChangeLog (282415 => 282416)
--- trunk/Source/WebCore/ChangeLog 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/ChangeLog 2021-09-14 22:25:25 UTC (rev 282416)
@@ -1,3 +1,15 @@
+2021-09-14 Ryan Haddad <[email protected]>
+
+ Unreviewed, reverting r282408.
+
+ Breaks internal builds.
+
+ Reverted changeset:
+
+ "Enable RTCRtpScriptTransform by default"
+ https://bugs.webkit.org/show_bug.cgi?id=230220
+ https://commits.webkit.org/r282408
+
2021-09-14 Myles C. Maxfield <[email protected]>
CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers
Modified: trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -34,7 +34,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=DedicatedWorker,
ImplementationLacksVTable,
] interface RTCEncodedAudioFrame {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -43,7 +43,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=DedicatedWorker,
ImplementationLacksVTable,
] interface RTCEncodedVideoFrame {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -27,7 +27,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=Window,
ImplementedBy=RTCRtpReceiverWithTransform,
] partial interface RTCRtpReceiver {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -43,7 +43,7 @@
[
ActiveDOMObject,
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCSFrameTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
ExportMacro=WEBCORE_EXPORT,
Exposed=(Window,DedicatedWorker),
InterfaceName=SFrameTransform,
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -36,7 +36,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCSFrameTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=(Window,DedicatedWorker),
InterfaceName=SFrameTransformErrorEvent
] interface RTCRtpSFrameTransformErrorEvent : Event {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=Window,
JSGenerateToNativeObject,
] interface RTCRtpScriptTransform : EventTarget {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=DedicatedWorker,
JSGenerateToNativeObject,
] interface RTCRtpScriptTransformer {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -27,7 +27,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=Window,
ImplementedBy=RTCRtpSenderWithTransform,
] partial interface RTCRtpSender {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl (282415 => 282416)
--- trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -24,7 +24,7 @@
[
Conditional=WEB_RTC,
- EnabledBySetting=WebRTCEncodedTransform,
+ EnabledBySetting=WebRTCInsertableStreams,
Exposed=Worker,
InterfaceName=RTCTransformEvent,
] interface RTCTransformEvent : Event {
Modified: trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl (282415 => 282416)
--- trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl 2021-09-14 22:19:41 UTC (rev 282415)
+++ trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl 2021-09-14 22:25:25 UTC (rev 282416)
@@ -46,4 +46,4 @@
};
[Conditional=OFFSCREEN_CANVAS_IN_WORKERS, EnabledAtRuntime=OffscreenCanvasInWorkers] DedicatedWorkerGlobalScope includes AnimationFrameProvider;
-[Conditional=WEB_RTC, EnabledBySetting=WebRTCEncodedTransform] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
+[Conditional=WEB_RTC, EnabledBySetting=WebRTCInsertableStreams] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
