Title: [282452] trunk/Source/WebCore
Revision
282452
Author
[email protected]
Date
2021-09-15 07:21:49 -0700 (Wed, 15 Sep 2021)

Log Message

[LFC][Integration] TextBoxSelectableRange::additionalLengthAtEnd miscomputed
https://bugs.webkit.org/show_bug.cgi?id=230306

Reviewed by Alan Bujtas.

It should be non-zero only if the run contains a hyphen. This doesn't yet affect
anything, but it will.

* layout/integration/LayoutIntegrationRunIteratorModernPath.h:
(WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (282451 => 282452)


--- trunk/Source/WebCore/ChangeLog	2021-09-15 13:46:47 UTC (rev 282451)
+++ trunk/Source/WebCore/ChangeLog	2021-09-15 14:21:49 UTC (rev 282452)
@@ -1,3 +1,16 @@
+2021-09-15  Antti Koivisto  <[email protected]>
+
+        [LFC][Integration] TextBoxSelectableRange::additionalLengthAtEnd miscomputed
+        https://bugs.webkit.org/show_bug.cgi?id=230306
+
+        Reviewed by Alan Bujtas.
+
+        It should be non-zero only if the run contains a hyphen. This doesn't yet affect
+        anything, but it will.
+
+        * layout/integration/LayoutIntegrationRunIteratorModernPath.h:
+        (WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):
+
 2021-09-15  Aditya Keerthi  <[email protected]>
 
         [iOS] Search inputs with '-webkit-appearance: textfield' should have a textfield background color

Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h (282451 => 282452)


--- trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h	2021-09-15 13:46:47 UTC (rev 282451)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h	2021-09-15 14:21:49 UTC (rev 282452)
@@ -105,7 +105,7 @@
         return {
             start(),
             length(),
-            run().style().hyphenString().length(),
+            run().text()->hasHyphen() ? run().style().hyphenString().length() : 0,
             run().isLineBreak()
         };
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to