Title: [282475] trunk/Source/WebInspectorUI
- Revision
- 282475
- Author
- [email protected]
- Date
- 2021-09-15 14:49:09 -0700 (Wed, 15 Sep 2021)
Log Message
Web Inspector: `DOMTreeUpdater` doesn't complete deferred updating/clear updated lists when a node isn't found in the tree
https://bugs.webkit.org/show_bug.cgi?id=230289
Reviewed by Devin Rousso.
Instead of an early return when a tree element can't be found, we should continue on to the next updated node
and finish out by clearing the collections of updated nodes, otherwise a node that will never be findable again
will cause extra work to be done on every update.
* UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (282474 => 282475)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-09-15 21:43:51 UTC (rev 282474)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-09-15 21:49:09 UTC (rev 282475)
@@ -1,3 +1,17 @@
+2021-09-15 Patrick Angle <[email protected]>
+
+ Web Inspector: `DOMTreeUpdater` doesn't complete deferred updating/clear updated lists when a node isn't found in the tree
+ https://bugs.webkit.org/show_bug.cgi?id=230289
+
+ Reviewed by Devin Rousso.
+
+ Instead of an early return when a tree element can't be found, we should continue on to the next updated node
+ and finish out by clearing the collections of updated nodes, otherwise a node that will never be findable again
+ will cause extra work to be done on every update.
+
+ * UserInterface/Views/DOMTreeUpdater.js:
+ (WI.DOMTreeUpdater.prototype._updateModifiedNodes):
+
2021-09-13 Razvan Caliman <[email protected]>
Web Inspector: Update naming of WI.CSSCompletions callback used for collecting supported CSS properties from the target
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js (282474 => 282475)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2021-09-15 21:43:51 UTC (rev 282474)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2021-09-15 21:49:09 UTC (rev 282475)
@@ -143,7 +143,7 @@
for (let node of this._recentlyModifiedNodes.values()) {
let nodeTreeElement = this._treeOutline.findTreeElement(node);
if (!nodeTreeElement)
- return;
+ continue;
for (let [attribute, nodes] of this._recentlyModifiedAttributes.entries()) {
// Don't report textContent changes as attribute modifications.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
