Title: [282494] trunk/Source/WebCore
- Revision
- 282494
- Author
- [email protected]
- Date
- 2021-09-16 00:41:10 -0700 (Thu, 16 Sep 2021)
Log Message
Use libwebrtc OnStandardizedIceConnectionChange callback instead of OnIceConnectionChange
https://bugs.webkit.org/show_bug.cgi?id=230314
Reviewed by Eric Carlson.
Migrate to standardized variant.
Covered by existing tests.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (282493 => 282494)
--- trunk/Source/WebCore/ChangeLog 2021-09-16 07:38:59 UTC (rev 282493)
+++ trunk/Source/WebCore/ChangeLog 2021-09-16 07:41:10 UTC (rev 282494)
@@ -1,3 +1,17 @@
+2021-09-16 Youenn Fablet <[email protected]>
+
+ Use libwebrtc OnStandardizedIceConnectionChange callback instead of OnIceConnectionChange
+ https://bugs.webkit.org/show_bug.cgi?id=230314
+
+ Reviewed by Eric Carlson.
+
+ Migrate to standardized variant.
+ Covered by existing tests.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange):
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+
2021-09-15 Philip Chimento <[email protected]>
Fixes for build-webkit --minimal
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (282493 => 282494)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2021-09-16 07:38:59 UTC (rev 282493)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2021-09-16 07:41:10 UTC (rev 282494)
@@ -521,7 +521,7 @@
return RTCIceConnectionState::New;
}
-void LibWebRTCMediaEndpoint::OnIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState state)
+void LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState state)
{
auto connectionState = toRTCIceConnectionState(state);
callOnMainThread([protectedThis = makeRef(*this), connectionState] {
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h (282493 => 282494)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2021-09-16 07:38:59 UTC (rev 282493)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2021-09-16 07:41:10 UTC (rev 282494)
@@ -128,7 +128,7 @@
void OnRemoveTrack(rtc::scoped_refptr<webrtc::RtpReceiverInterface>) final;
void OnNegotiationNeededEvent(uint32_t) final;
- void OnIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState) final;
+ void OnStandardizedIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState) final;
void OnIceGatheringChange(webrtc::PeerConnectionInterface::IceGatheringState) final;
void OnIceCandidate(const webrtc::IceCandidateInterface*) final;
void OnIceCandidatesRemoved(const std::vector<cricket::Candidate>&) final;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
