Title: [282499] releases/WebKitGTK/webkit-2.32/Source/WebCore
Revision
282499
Author
[email protected]
Date
2021-09-16 01:00:25 -0700 (Thu, 16 Sep 2021)

Log Message

Merge r275807 - Store InputType in a Ref before calling setValueAsDecimal
https://bugs.webkit.org/show_bug.cgi?id=223535

Patch by Rob Buis <[email protected]> on 2021-04-11
Reviewed by Ryosuke Niwa.

Store InputType in a Ref before calling setValueAsDecimal.

* html/InputType.cpp:
(WebCore::InputType::applyStep):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (282498 => 282499)


--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-09-16 08:00:19 UTC (rev 282498)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog	2021-09-16 08:00:25 UTC (rev 282499)
@@ -1,3 +1,15 @@
+2021-04-11  Rob Buis  <[email protected]>
+
+        Store InputType in a Ref before calling setValueAsDecimal
+        https://bugs.webkit.org/show_bug.cgi?id=223535
+
+        Reviewed by Ryosuke Niwa.
+
+        Store InputType in a Ref before calling setValueAsDecimal.
+
+        * html/InputType.cpp:
+        (WebCore::InputType::applyStep):
+
 2021-04-09  Carlos Garcia Campos  <[email protected]>
 
         Teardown shadow root renderers on SlotAssignment::didChangeSlot

Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/html/InputType.cpp (282498 => 282499)


--- releases/WebKitGTK/webkit-2.32/Source/WebCore/html/InputType.cpp	2021-09-16 08:00:19 UTC (rev 282498)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/html/InputType.cpp	2021-09-16 08:00:25 UTC (rev 282499)
@@ -929,8 +929,9 @@
     if (newValue > stepRange.maximum())
         newValue = stepRange.maximum();
 
+    auto protectedThis = makeRef(*this);
     auto result = setValueAsDecimal(newValue, eventBehavior);
-    if (result.hasException())
+    if (result.hasException() || !element())
         return result;
 
     if (AXObjectCache* cache = element()->document().existingAXObjectCache())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to