Title: [282501] releases/WebKitGTK/webkit-2.32/Source/WebCore
- Revision
- 282501
- Author
- [email protected]
- Date
- 2021-09-16 01:09:11 -0700 (Thu, 16 Sep 2021)
Log Message
Merge r275876 - Skip style update
https://bugs.webkit.org/show_bug.cgi?id=223365
Patch by Rob Buis <[email protected]> on 2021-04-13
Reviewed by Ryosuke Niwa.
Skip style update for getting the SVG bounding box
since boundingClientRect already updated style.
* dom/Element.cpp:
(WebCore::Element::boundingAbsoluteRectWithoutLayout):
* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (282500 => 282501)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-16 08:00:36 UTC (rev 282500)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-16 08:09:11 UTC (rev 282501)
@@ -1,3 +1,18 @@
+2021-04-13 Rob Buis <[email protected]>
+
+ Skip style update
+ https://bugs.webkit.org/show_bug.cgi?id=223365
+
+ Reviewed by Ryosuke Niwa.
+
+ Skip style update for getting the SVG bounding box
+ since boundingClientRect already updated style.
+
+ * dom/Element.cpp:
+ (WebCore::Element::boundingAbsoluteRectWithoutLayout):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::getBoundingBox):
+
2021-04-12 BJ Burg <[email protected]>
Modernize uses of ConsoleClient
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Element.cpp (282500 => 282501)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Element.cpp 2021-09-16 08:00:36 UTC (rev 282500)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Element.cpp 2021-09-16 08:09:11 UTC (rev 282501)
@@ -1613,7 +1613,7 @@
// Get the bounding rectangle from the SVG model.
SVGElement& svgElement = downcast<SVGElement>(*this);
FloatRect localRect;
- if (svgElement.getBoundingBox(localRect))
+ if (svgElement.getBoundingBox(localRect, SVGLocatable::DisallowStyleUpdate))
quads.append(renderer->localToAbsoluteQuad(localRect));
} else if (auto pair = listBoxElementBoundingBox(*this)) {
renderer = pair.value().first;
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp (282500 => 282501)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp 2021-09-16 08:00:36 UTC (rev 282500)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp 2021-09-16 08:09:11 UTC (rev 282501)
@@ -293,6 +293,7 @@
bool SVGElement::getBoundingBox(FloatRect& rect, SVGLocatable::StyleUpdateStrategy styleUpdateStrategy)
{
+ // FIXME: should retrieve the value from the associated RenderObject.
if (is<SVGGraphicsElement>(*this)) {
rect = downcast<SVGGraphicsElement>(*this).getBBox(styleUpdateStrategy);
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
