Title: [282504] releases/WebKitGTK/webkit-2.32/Source/WebCore
- Revision
- 282504
- Author
- [email protected]
- Date
- 2021-09-16 01:14:51 -0700 (Thu, 16 Sep 2021)
Log Message
Merge r275994 - Crash in in ReplaceSelectionCommand::mergeEndIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=222941
Unreviewed. Address Darin's post-commit comment that we don't need to explicitly call copyRef here.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (282503 => 282504)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-16 08:14:44 UTC (rev 282503)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-16 08:14:51 UTC (rev 282504)
@@ -1,3 +1,13 @@
+2021-04-14 Ryosuke Niwa <[email protected]>
+
+ Crash in in ReplaceSelectionCommand::mergeEndIfNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=222941
+
+ Unreviewed. Address Darin's post-commit comment that we don't need to explicitly call copyRef here.
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
+
2021-04-14 Julian Gonzalez <[email protected]>
Crash in ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds()
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/editing/ReplaceSelectionCommand.cpp (282503 => 282504)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2021-09-16 08:14:44 UTC (rev 282503)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2021-09-16 08:14:51 UTC (rev 282504)
@@ -967,7 +967,7 @@
// To avoid this, we add a placeholder node before the start of the paragraph.
if (endOfParagraph(startOfParagraphToMove) == destination) {
auto placeholder = HTMLBRElement::create(document());
- insertNodeBefore(placeholder.copyRef(), *startOfParagraphToMove.deepEquivalent().deprecatedNode());
+ insertNodeBefore(placeholder, *startOfParagraphToMove.deepEquivalent().deprecatedNode());
destination = VisiblePosition(positionBeforeNode(placeholder.ptr()));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
