- Revision
- 106535
- Author
- [email protected]
- Date
- 2012-02-01 23:48:28 -0800 (Wed, 01 Feb 2012)
Log Message
Rename [V8DisallowShadowing] to [V8Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=77599
Reviewed by Adam Barth.
This patch renames [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL
spec (http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable).
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
* page/DOMWindow.idl:
* page/Location.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106534 => 106535)
--- trunk/Source/WebCore/ChangeLog 2012-02-02 07:07:50 UTC (rev 106534)
+++ trunk/Source/WebCore/ChangeLog 2012-02-02 07:48:28 UTC (rev 106535)
@@ -1,5 +1,24 @@
2012-02-01 Kentaro Hara <[email protected]>
+ Rename [V8DisallowShadowing] to [V8Unforgeable]
+ https://bugs.webkit.org/show_bug.cgi?id=77599
+
+ Reviewed by Adam Barth.
+
+ This patch renames [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL
+ spec (http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable).
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrGetter):
+ (GenerateSingleBatchedAttribute):
+ (GenerateImplementation):
+ * page/DOMWindow.idl:
+ * page/Location.idl:
+
+2012-02-01 Kentaro Hara <[email protected]>
+
Rename [ConvertNullToNullString] to [TreatNullAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77602
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (106534 => 106535)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-02 07:07:50 UTC (rev 106534)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-02 07:48:28 UTC (rev 106535)
@@ -829,7 +829,7 @@
END
}
}
- } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8DisallowShadowing"}) {
+ } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8Unforgeable"}) {
if ($interfaceName eq "DOMWindow") {
push(@implContentDecls, <<END);
v8::Handle<v8::Object> holder = info.Holder();
@@ -1948,7 +1948,7 @@
$accessControl .= " | v8::ALL_CAN_WRITE";
}
}
- if ($attrExt->{"V8DisallowShadowing"}) {
+ if ($attrExt->{"V8Unforgeable"}) {
$accessControl .= " | v8::PROHIBITS_OVERWRITING";
}
$accessControl = "static_cast<v8::AccessControl>(" . $accessControl . ")";
@@ -1975,7 +1975,7 @@
if ($attrExt->{"DontEnum"}) {
$propAttr .= " | v8::DontEnum";
}
- if ($attrExt->{"V8DisallowShadowing"}) {
+ if ($attrExt->{"V8Unforgeable"}) {
$propAttr .= " | v8::DontDelete";
}
@@ -2366,7 +2366,7 @@
my @normal;
foreach my $attribute (@$attributes) {
- if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8DisallowShadowing"}) {
+ if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8Unforgeable"}) {
push(@disallowsShadowing, $attribute);
} elsif ($attribute->signature->extendedAttributes->{"EnabledAtRuntime"}) {
push(@enabledAtRuntime, $attribute);
Modified: trunk/Source/WebCore/page/DOMWindow.idl (106534 => 106535)
--- trunk/Source/WebCore/page/DOMWindow.idl 2012-02-02 07:07:50 UTC (rev 106534)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2012-02-02 07:48:28 UTC (rev 106535)
@@ -54,7 +54,7 @@
attribute [Replaceable] Navigator navigator;
attribute [Replaceable] Navigator clientInformation;
readonly attribute Crypto crypto;
- attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8DisallowShadowing, CPPCustom] Location location;
+ attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
@@ -129,12 +129,12 @@
// Self referential attributes
attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow self;
- readonly attribute [DoNotCheckDomainSecurity, V8DisallowShadowing] DOMWindow window;
+ readonly attribute [DoNotCheckDomainSecurity, V8Unforgeable] DOMWindow window;
attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow frames;
attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8CustomSetter] DOMWindow opener;
attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow parent;
- attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8DisallowShadowing, V8ReadOnly] DOMWindow top;
+ attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8Unforgeable, V8ReadOnly] DOMWindow top;
// DOM Level 2 AbstractView Interface
readonly attribute Document document;
Modified: trunk/Source/WebCore/page/Location.idl (106534 => 106535)
--- trunk/Source/WebCore/page/Location.idl 2012-02-02 07:07:50 UTC (rev 106534)
+++ trunk/Source/WebCore/page/Location.idl 2012-02-02 07:48:28 UTC (rev 106535)
@@ -43,7 +43,7 @@
OmitConstructor
] Location {
#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
- attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8DisallowShadowing] DOMString href;
+ attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8Unforgeable] DOMString href;
#endif
[Custom, V8OnInstance] void assign(in [Optional=CallWithDefaultValue] DOMString url);
