Title: [282601] trunk/Tools
- Revision
- 282601
- Author
- megan_gard...@apple.com
- Date
- 2021-09-16 14:35:22 -0700 (Thu, 16 Sep 2021)
Log Message
Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with changing menu states.
https://bugs.webkit.org/show_bug.cgi?id=230363
rdar://82099562
Reviewed by Wenson Hsieh.
The tests assumes that both menu items would be available, but that was changed to be based on the visibility
of the quick note window, so update the test accordingly.
* TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (282600 => 282601)
--- trunk/Tools/ChangeLog 2021-09-16 21:07:54 UTC (rev 282600)
+++ trunk/Tools/ChangeLog 2021-09-16 21:35:22 UTC (rev 282601)
@@ -1,3 +1,17 @@
+2021-09-16 Megan Gardner <megan_gard...@apple.com>
+
+ Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with changing menu states.
+ https://bugs.webkit.org/show_bug.cgi?id=230363
+ rdar://82099562
+
+ Reviewed by Wenson Hsieh.
+
+ The tests assumes that both menu items would be available, but that was changed to be based on the visibility
+ of the quick note window, so update the test accordingly.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
+ (TEST):
+
2021-09-16 Youenn Fablet <you...@apple.com>
Add an option to disable linter in WPT test exporter
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm (282600 => 282601)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm 2021-09-16 21:07:54 UTC (rev 282600)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm 2021-09-16 21:35:22 UTC (rev 282601)
@@ -98,7 +98,7 @@
[webView synchronouslyLoadTestPageNamed:@"simple"];
[webView selectAll:nil];
[webView waitForNextPresentationUpdate];
- EXPECT_EQ([contentView targetForAction:createHighlightForCurrentQuickNoteWithRangeSelector withSender:nil], contentView);
+ EXPECT_NULL([contentView targetForAction:createHighlightForCurrentQuickNoteWithRangeSelector withSender:nil]);
EXPECT_EQ([contentView targetForAction:createHighlightForNewQuickNoteWithRangeSelector withSender:nil], contentView);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
