Title: [282611] trunk/Source/WebKit
Revision
282611
Author
cdu...@apple.com
Date
2021-09-16 15:46:32 -0700 (Thu, 16 Sep 2021)

Log Message

Stringify process termination reason in dispatchProcessDidTerminate logging
https://bugs.webkit.org/show_bug.cgi?id=230361

Reviewed by Geoffrey Garen.

* UIProcess/WebPageProxy.cpp:
(WebKit::processTerminationReasonToString):
(WebKit::WebPageProxy::dispatchProcessDidTerminate):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (282610 => 282611)


--- trunk/Source/WebKit/ChangeLog	2021-09-16 22:35:25 UTC (rev 282610)
+++ trunk/Source/WebKit/ChangeLog	2021-09-16 22:46:32 UTC (rev 282611)
@@ -1,5 +1,16 @@
 2021-09-16  Chris Dumez  <cdu...@apple.com>
 
+        Stringify process termination reason in dispatchProcessDidTerminate logging
+        https://bugs.webkit.org/show_bug.cgi?id=230361
+
+        Reviewed by Geoffrey Garen.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::processTerminationReasonToString):
+        (WebKit::WebPageProxy::dispatchProcessDidTerminate):
+
+2021-09-16  Chris Dumez  <cdu...@apple.com>
+
         Add violations reporting support for Cross-Origin-Embedder-Policy
         https://bugs.webkit.org/show_bug.cgi?id=230269
 

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (282610 => 282611)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-09-16 22:35:25 UTC (rev 282610)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-09-16 22:46:32 UTC (rev 282611)
@@ -7755,9 +7755,32 @@
     return false;
 }
 
+static const char* processTerminationReasonToString(ProcessTerminationReason reason)
+{
+    switch (reason) {
+    case ProcessTerminationReason::ExceededMemoryLimit:
+        return "ExceededMemoryLimit";
+    case ProcessTerminationReason::ExceededCPULimit:
+        return "ExceededCPULimit";
+    case ProcessTerminationReason::RequestedByNetworkProcess:
+        return "RequestedByNetworkProcess";
+    case ProcessTerminationReason::RequestedByGPUProcess:
+        return "RequestedByGPUProcess";
+    case ProcessTerminationReason::ExceededProcessCountLimit:
+        return "ExceededProcessCountLimit";
+    case ProcessTerminationReason::NavigationSwap:
+        return "NavigationSwap";
+    case ProcessTerminationReason::RequestedByClient:
+        return "RequestedByClient";
+    case ProcessTerminationReason::Crash:
+        break;
+    }
+    return "Crash";
+}
+
 void WebPageProxy::dispatchProcessDidTerminate(ProcessTerminationReason reason)
 {
-    WEBPAGEPROXY_RELEASE_LOG_ERROR(Loading, "dispatchProcessDidTerminate: reason=%d", reason);
+    WEBPAGEPROXY_RELEASE_LOG_ERROR(Loading, "dispatchProcessDidTerminate: reason=%{public}s", processTerminationReasonToString(reason));
 
     bool handledByClient = false;
     if (m_loaderClient)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to