Diff
Modified: trunk/LayoutTests/ChangeLog (282635 => 282636)
--- trunk/LayoutTests/ChangeLog 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/ChangeLog 2021-09-17 06:46:59 UTC (rev 282636)
@@ -1,3 +1,13 @@
+2021-09-16 Youenn Fablet <[email protected]>
+
+ WPT webrtc RTCPeerConnection-setLocalDescription-offer.html and RTCPeerConnection-setLocalDescription-answer.html are flaky due to always changing failing assertion
+ https://bugs.webkit.org/show_bug.cgi?id=230302
+
+ Reviewed by Eric Carlson.
+
+ * TestExpectations:
+ Unflake tests.
+
2021-09-16 Cameron McCormack <[email protected]>
Preserve canvas color space when producing JPEGs from toDataURL/toBlob
Modified: trunk/LayoutTests/TestExpectations (282635 => 282636)
--- trunk/LayoutTests/TestExpectations 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/TestExpectations 2021-09-17 06:46:59 UTC (rev 282636)
@@ -2189,8 +2189,6 @@
imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html [ Pass Failure Slow ]
webkit.org/b/214197 imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html [ Pass Failure Crash ]
-imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
-imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html [ Failure ]
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html [ Pass Failure ]
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-timing.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/webrtc/protocol/split.https.html [ Pass Failure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282635 => 282636)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-17 06:46:59 UTC (rev 282636)
@@ -1,3 +1,17 @@
+2021-09-16 Youenn Fablet <[email protected]>
+
+ WPT webrtc RTCPeerConnection-setLocalDescription-offer.html and RTCPeerConnection-setLocalDescription-answer.html are flaky due to always changing failing assertion
+ https://bugs.webkit.org/show_bug.cgi?id=230302
+
+ Reviewed by Eric Carlson.
+
+ Update the test to just check for exception name so that, when failing, the error message stays stable.
+
+ * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
+ * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html:
+ * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
+ * web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html:
+
2021-09-16 Cameron McCormack <[email protected]>
Preserve canvas color space when producing JPEGs from toDataURL/toBlob
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt (282635 => 282636)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt 2021-09-17 06:46:59 UTC (rev 282636)
@@ -1,7 +1,7 @@
PASS setLocalDescription() with valid answer should succeed
PASS setLocalDescription() with type answer and null sdp should use lastAnswer generated from createAnswer
-FAIL setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError promise_rejects_dom: function "function () { throw e }" threw object "OperationError: Failed to set local answer sdp: Failed to apply the description for m= section with mid='0': Local fingerprint does not match identity. Expected: sha-256 E0:10:A4:25:B7:9C:C3:34:17:6B:E8:00:18:CF:06:6A:EE:69:CD:73:98:19:59:50:B0:94:82:E7:5D:1D:8A:9A Got: sha-256 8A:BB:25:66:6B:B6:12:70:27:22:6E:E1:13:A4:5D:5D:50:A9:C0:26:8E:C9:7E:31:37:93:9B:5B:E1:23:2E:8B" that is not a DOMException InvalidModificationError: property "code" is equal to 0, expected 13
+FAIL setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError assert_equals: expected "InvalidModificationError" but got "OperationError"
FAIL Calling setLocalDescription(answer) from stable state should reject with InvalidModificationError promise_rejects_dom: function "function () { throw e }" threw object "InvalidStateError: Failed to set local answer sdp: no pending remote description." that is not a DOMException InvalidModificationError: property "code" is equal to 11, expected 13
FAIL Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidModificationError promise_rejects_dom: function "function () { throw e }" threw object "InvalidStateError: Failed to set local answer sdp: no pending remote description." that is not a DOMException InvalidModificationError: property "code" is equal to 11, expected 13
PASS Setting previously generated answer after a call to createOffer should work
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html (282635 => 282636)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html 2021-09-17 06:46:59 UTC (rev 282636)
@@ -131,9 +131,9 @@
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => generateAnswer(offer))
- .then(answer =>
- promise_rejects_dom(t, 'InvalidModificationError',
- pc.setLocalDescription(answer))));
+ .then(answer => pc.setLocalDescription(answer))
+ .then(() => t.unreached_func("setLocalDescription should have rejected"),
+ (error) => assert_equals(error.name, 'InvalidModificationError')));
}, 'setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError');
/*
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt (282635 => 282636)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt 2021-09-17 06:46:59 UTC (rev 282636)
@@ -1,7 +1,7 @@
PASS setLocalDescription with valid offer should succeed
PASS setLocalDescription with type offer and null sdp should use lastOffer generated from createOffer
-FAIL setLocalDescription() with offer not created by own createOffer() should reject with InvalidModificationError promise_rejects_dom: function "function () { throw e }" threw object "OperationError: Failed to set local offer sdp: Failed to apply the description for m= section with mid='0': Local fingerprint does not match identity. Expected: sha-256 2E:44:69:5B:86:09:8A:4E:50:8B:E8:D4:CF:C6:38:93:78:A2:D1:0E:91:37:A6:FA:41:6F:CD:9B:94:3D:22:FD Got: sha-256 62:F4:16:A1:2F:35:30:DA:D6:B8:94:CE:1E:5A:70:A0:36:7B:5B:80:05:B3:EE:6D:95:A3:8D:BD:42:38:41:79" that is not a DOMException InvalidModificationError: property "code" is equal to 0, expected 13
+FAIL setLocalDescription() with offer not created by own createOffer() should reject with InvalidModificationError assert_equals: expected "InvalidModificationError" but got "OperationError"
FAIL Set created offer other than last offer should reject with InvalidModificationError assert_unreached: Should have rejected: undefined Reached unreachable code
PASS Creating and setting offer multiple times should succeed
PASS Setting previously generated offer after a call to createAnswer should work
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html (282635 => 282636)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html 2021-09-17 06:31:10 UTC (rev 282635)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html 2021-09-17 06:46:59 UTC (rev 282636)
@@ -110,9 +110,9 @@
t.add_cleanup(() => pc2.close());
return generateDataChannelOffer(pc)
- .then(offer =>
- promise_rejects_dom(t, 'InvalidModificationError',
- pc2.setLocalDescription(offer)));
+ .then(offer => pc2.setLocalDescription(offer))
+ .then(() => t.unreached_func("setLocalDescription should have rejected"),
+ (error) => assert_equals(error.name, 'InvalidModificationError'));
}, 'setLocalDescription() with offer not created by own createOffer() should reject with InvalidModificationError');
promise_test(t => {
