Title: [282693] trunk/Source/WebKit
Revision
282693
Author
[email protected]
Date
2021-09-17 14:19:57 -0700 (Fri, 17 Sep 2021)

Log Message

Unreviewed, reverting r282011.

This causes GPUProcess main thread hangs on memory pressure

Reverted changeset:

"Fix race in
RemoteRenderingBackend::allowsExitUnderMemoryPressure()"
https://bugs.webkit.org/show_bug.cgi?id=229870
https://commits.webkit.org/r282011

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (282692 => 282693)


--- trunk/Source/WebKit/ChangeLog	2021-09-17 21:12:21 UTC (rev 282692)
+++ trunk/Source/WebKit/ChangeLog	2021-09-17 21:19:57 UTC (rev 282693)
@@ -1,3 +1,16 @@
+2021-09-17  Chris Dumez  <[email protected]>
+
+        Unreviewed, reverting r282011.
+
+        This causes GPUProcess main thread hangs on memory pressure
+
+        Reverted changeset:
+
+        "Fix race in
+        RemoteRenderingBackend::allowsExitUnderMemoryPressure()"
+        https://bugs.webkit.org/show_bug.cgi?id=229870
+        https://commits.webkit.org/r282011
+
 2021-09-17  Per Arne Vollan  <[email protected]>
 
         [GPUP] Update AX settings on preference updates

Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (282692 => 282693)


--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp	2021-09-17 21:12:21 UTC (rev 282692)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp	2021-09-17 21:19:57 UTC (rev 282693)
@@ -681,12 +681,7 @@
 
 bool RemoteRenderingBackend::allowsExitUnderMemoryPressure() const
 {
-    ASSERT(isMainRunLoop());
-    bool hasActiveDrawables = false;
-    m_workQueue->dispatchSync([this, &hasActiveDrawables] {
-        hasActiveDrawables = !m_remoteResourceCache.imageBuffers().isEmpty() || !m_remoteResourceCache.nativeImages().isEmpty();
-    });
-    return !hasActiveDrawables;
+    return m_remoteResourceCache.imageBuffers().isEmpty() && m_remoteResourceCache.nativeImages().isEmpty();
 }
 
 RemoteRenderingBackendState RemoteRenderingBackend::lastKnownState() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to