Title: [282706] trunk/Source/WebCore
- Revision
- 282706
- Author
- [email protected]
- Date
- 2021-09-17 16:15:45 -0700 (Fri, 17 Sep 2021)
Log Message
Add CustomToJSObject wrapper for CSSStyleValueCustom
https://bugs.webkit.org/show_bug.cgi?id=230422
Patch by Johnson Zhou <[email protected]> on 2021-09-17
Reviewed by Alex Christensen.
* bindings/js/JSCSSStyleValueCustom.cpp:
(WebCore::toJSNewlyCreated):
* css/typedom/CSSKeywordValue.h:
(isType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (282705 => 282706)
--- trunk/Source/WebCore/ChangeLog 2021-09-17 23:13:39 UTC (rev 282705)
+++ trunk/Source/WebCore/ChangeLog 2021-09-17 23:15:45 UTC (rev 282706)
@@ -1,5 +1,17 @@
2021-09-17 Johnson Zhou <[email protected]>
+ Add CustomToJSObject wrapper for CSSStyleValueCustom
+ https://bugs.webkit.org/show_bug.cgi?id=230422
+
+ Reviewed by Alex Christensen.
+
+ * bindings/js/JSCSSStyleValueCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * css/typedom/CSSKeywordValue.h:
+ (isType):
+
+2021-09-17 Johnson Zhou <[email protected]>
+
Addition of CSSTransformValue, CSSTransformComponent & subclasses
https://bugs.webkit.org/show_bug.cgi?id=230284
Modified: trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp (282705 => 282706)
--- trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp 2021-09-17 23:13:39 UTC (rev 282705)
+++ trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp 2021-09-17 23:15:45 UTC (rev 282706)
@@ -28,6 +28,9 @@
#if ENABLE(CSS_TYPED_OM)
+#include "JSCSSKeywordValue.h"
+#include "JSCSSMathValue.h"
+#include "JSCSSNumericValue.h"
#include "JSCSSStyleImageValue.h"
#include "JSCSSUnitValue.h"
#include "JSCSSUnparsedValue.h"
@@ -39,16 +42,22 @@
JSValue toJSNewlyCreated(JSGlobalObject*, JSDOMGlobalObject* globalObject, Ref<CSSStyleValue>&& value)
{
switch (value->getType()) {
+ case CSSStyleValueType::CSSStyleImageValue:
+ return createWrapper<CSSStyleImageValue>(globalObject, WTFMove(value));
+ case CSSStyleValueType::CSSNumericValue:
+ return createWrapper<CSSNumericValue>(globalObject, WTFMove(value));
+ case CSSStyleValueType::CSSMathValue:
+ return createWrapper<CSSMathValue>(globalObject, WTFMove(value));
case CSSStyleValueType::CSSUnitValue:
return createWrapper<CSSUnitValue>(globalObject, WTFMove(value));
case CSSStyleValueType::CSSUnparsedValue:
return createWrapper<CSSUnparsedValue>(globalObject, WTFMove(value));
- case CSSStyleValueType::CSSStyleImageValue:
- return createWrapper<CSSStyleImageValue>(globalObject, WTFMove(value));
- default:
+ case CSSStyleValueType::CSSKeywordValue:
+ return createWrapper<CSSKeywordValue>(globalObject, WTFMove(value));
+ case CSSStyleValueType::CSSTransformValue:
+ case CSSStyleValueType::CSSStyleValue:
return createWrapper<CSSStyleValue>(globalObject, WTFMove(value));
}
-
}
JSValue toJS(JSGlobalObject* lexicalGlobalObject, JSDOMGlobalObject* globalObject, CSSStyleValue& object)
Modified: trunk/Source/WebCore/css/typedom/CSSKeywordValue.h (282705 => 282706)
--- trunk/Source/WebCore/css/typedom/CSSKeywordValue.h 2021-09-17 23:13:39 UTC (rev 282705)
+++ trunk/Source/WebCore/css/typedom/CSSKeywordValue.h 2021-09-17 23:15:45 UTC (rev 282706)
@@ -53,7 +53,7 @@
} // namespace WebCore
SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::CSSKeywordValue)
- static bool isType(const WebCore::CSSKeywordValue& styleValue) { return styleValue.getType() == WebCore::CSSStyleValueType::CSSKeywordValue; }
+ static bool isType(const WebCore::CSSStyleValue& styleValue) { return styleValue.getType() == WebCore::CSSStyleValueType::CSSKeywordValue; }
SPECIALIZE_TYPE_TRAITS_END()
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
