Title: [282717] trunk/Tools
- Revision
- 282717
- Author
- [email protected]
- Date
- 2021-09-17 17:43:22 -0700 (Fri, 17 Sep 2021)
Log Message
[results.webkit.org] Add ability to access Bugzilla and Radar links from commit messages
https://bugs.webkit.org/show_bug.cgi?id=229160
Patch by Kevin Neal <[email protected]> on 2021-09-17
Reviewed by Jonathan Bedard.
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
(.tooltip-content hr):
(@media (prefers-color-scheme: dark) .tooltip-content hr):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
(Commit):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(xAxisFromScale):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (282716 => 282717)
--- trunk/Tools/ChangeLog 2021-09-18 00:39:32 UTC (rev 282716)
+++ trunk/Tools/ChangeLog 2021-09-18 00:43:22 UTC (rev 282717)
@@ -1,3 +1,18 @@
+2021-09-17 Kevin Neal <[email protected]>
+
+ [results.webkit.org] Add ability to access Bugzilla and Radar links from commit messages
+ https://bugs.webkit.org/show_bug.cgi?id=229160
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
+ (.tooltip-content hr):
+ (@media (prefers-color-scheme: dark) .tooltip-content hr):
+ * Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
+ (Commit):
+ * Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+ (xAxisFromScale):
+
2021-09-17 Jonathan Bedard <[email protected]>
[git-webkit] Reset author time when editing commits (Follow-up fix)
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css (282716 => 282717)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css 2021-09-18 00:39:32 UTC (rev 282716)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css 2021-09-18 00:43:22 UTC (rev 282717)
@@ -64,3 +64,13 @@
min-width: 30px;
min-height: 30px;
}
+
+.tooltip-content hr {
+ border: .5px solid black;
+}
+
+@media (prefers-color-scheme: dark) {
+ .tooltip-content hr {
+ border: .5px solid white;
+ }
+}
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js (282716 => 282717)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js 2021-09-18 00:39:32 UTC (rev 282716)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js 2021-09-18 00:43:22 UTC (rev 282717)
@@ -142,6 +142,10 @@
this.branch = json.branch;
this.message = json.message;
+ //FIXME: Need to create a more general solution for tracking bugs
+ this.bugUrls = json.message.match(/\b(https?):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);
+ this.radarUrls = json.message.match(/\b(rdar):\/{2}[^\s<>&]+[^\.\s<>&,)]/gmi);
+
this.timestamp = json.timestamp;
this.order = json.order;
this.uuid = this.timestamp * TIMESTAMP_TO_UUID_MULTIPLIER + this.order;
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js (282716 => 282717)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2021-09-18 00:39:32 UTC (rev 282716)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2021-09-18 00:43:22 UTC (rev 282717)
@@ -194,6 +194,9 @@
${node.label.author ? `<br>Author: ${escapeHTML(node.label.author.name)}
<<a href="" : ''}
${node.label.message ? `<br><div>${linkify(escapeHTML(node.label.message.split('\n')[0]))}</div>` : ''}
+ ${node.label.bugUrls || node.label.radarUrls ? '<hr>' : ''}
+ ${node.label.bugUrls ? `<div>${linkify(escapeHTML(node.label.bugUrls.join('\n').split('\n')[0]))}</div>` : ''}
+ ${node.label.radarUrls ? `<div>${linkify(escapeHTML(node.label.radarUrls.join('\n').split('\n')[0]))}</div>` : ''}
</div>`,
node.tipPoints.map((point) => {
return {x: canvas.x + point.x, y: canvas.y + scrollDelta + point.y};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
