Title: [282801] trunk/Source/WebCore
Revision
282801
Author
[email protected]
Date
2021-09-21 00:08:56 -0700 (Tue, 21 Sep 2021)

Log Message

[css-grid] FlexType is not applicable to min track sizing
https://bugs.webkit.org/show_bug.cgi?id=230405

Reviewed by Sergio Villar Senin.

For min track sizing, flexType is not applicable and shouldn't need a check.
This change is to remove the check that should not happen. No behaviour changes with
this change.

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::spanningItemCrossesFlexibleSizedTracks const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (282800 => 282801)


--- trunk/Source/WebCore/ChangeLog	2021-09-21 05:27:09 UTC (rev 282800)
+++ trunk/Source/WebCore/ChangeLog	2021-09-21 07:08:56 UTC (rev 282801)
@@ -1,3 +1,17 @@
+2021-09-21  Ziran Sun  <[email protected]>
+
+        [css-grid] FlexType is not applicable to min track sizing
+        https://bugs.webkit.org/show_bug.cgi?id=230405
+
+        Reviewed by Sergio Villar Senin.
+
+        For min track sizing, flexType is not applicable and shouldn't need a check.
+        This change is to remove the check that should not happen. No behaviour changes with
+        this change.
+
+        * rendering/GridTrackSizingAlgorithm.cpp:
+        (WebCore::GridTrackSizingAlgorithm::spanningItemCrossesFlexibleSizedTracks const):
+
 2021-09-20  Chris Dumez  <[email protected]>
 
         Drop remaining uses of makeRefPtr() in WebCore/

Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (282800 => 282801)


--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2021-09-21 05:27:09 UTC (rev 282800)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp	2021-09-21 07:08:56 UTC (rev 282801)
@@ -265,7 +265,7 @@
     const Vector<GridTrack>& trackList = tracks(m_direction);
     for (auto trackPosition : itemSpan) {
         const auto& trackSize = trackList[trackPosition].cachedTrackSize();
-        if (trackSize.minTrackBreadth().isFlex() || trackSize.maxTrackBreadth().isFlex())
+        if (trackSize.maxTrackBreadth().isFlex())
             return true;
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to