Title: [282808] trunk/Source/_javascript_Core
- Revision
- 282808
- Author
- [email protected]
- Date
- 2021-09-21 02:22:55 -0700 (Tue, 21 Sep 2021)
Log Message
Prevent test from accessing FP registers if they are not available (e.g., arm softFP)
https://bugs.webkit.org/show_bug.cgi?id=230493
Unreviewed gardening.
The patch from https://bugs.webkit.org/show_bug.cgi?id=228543 introduced
explicity calls to FP registers, however, they are not available in archs
that emulate FPs. This patch adds an #ifdef to only enable the test if
the arch has FP registers.
Patch by Mikhail R. Gadelha <[email protected]> on 2021-09-21
* assembler/testmasm.cpp:
(JSC::testStoreBaseIndex):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (282807 => 282808)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-21 09:21:45 UTC (rev 282807)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-21 09:22:55 UTC (rev 282808)
@@ -1,3 +1,18 @@
+2021-09-21 Mikhail R. Gadelha <[email protected]>
+
+ Prevent test from accessing FP registers if they are not available (e.g., arm softFP)
+ https://bugs.webkit.org/show_bug.cgi?id=230493
+
+ Unreviewed gardening.
+
+ The patch from https://bugs.webkit.org/show_bug.cgi?id=228543 introduced
+ explicity calls to FP registers, however, they are not available in archs
+ that emulate FPs. This patch adds an #ifdef to only enable the test if
+ the arch has FP registers.
+
+ * assembler/testmasm.cpp:
+ (JSC::testStoreBaseIndex):
+
2021-09-20 Chris Dumez <[email protected]>
Stop using makeRef(*this) / makeRefPtr(this)
Modified: trunk/Source/_javascript_Core/assembler/testmasm.cpp (282807 => 282808)
--- trunk/Source/_javascript_Core/assembler/testmasm.cpp 2021-09-21 09:21:45 UTC (rev 282807)
+++ trunk/Source/_javascript_Core/assembler/testmasm.cpp 2021-09-21 09:22:55 UTC (rev 282808)
@@ -5413,6 +5413,7 @@
CHECK_EQ(array[4], UINT8_MAX - 42);
}
+#if CPU(ARM_HARDFP)
// storeDouble
{
auto test = compile([=](CCallHelpers& jit) {
@@ -5460,6 +5461,7 @@
invoke<void>(test, array, static_cast<UCPURegister>(3), 42.0f);
CHECK_EQ(array[4], 42.0f);
}
+#endif
}
static void testCagePreservesPACFailureBit()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
