Title: [282832] trunk/Source/_javascript_Core
- Revision
- 282832
- Author
- [email protected]
- Date
- 2021-09-21 11:43:34 -0700 (Tue, 21 Sep 2021)
Log Message
Replace a few ASSERTs with static_asserts in the ARM64 MacroAssemblers.
https://bugs.webkit.org/show_bug.cgi?id=230569
Reviewed by Yusuke Suzuki.
* assembler/ARM64Assembler.h:
* assembler/ARM64EAssembler.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (282831 => 282832)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-21 18:30:37 UTC (rev 282831)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-21 18:43:34 UTC (rev 282832)
@@ -1,3 +1,13 @@
+2021-09-21 Mark Lam <[email protected]>
+
+ Replace a few ASSERTs with static_asserts in the ARM64 MacroAssemblers.
+ https://bugs.webkit.org/show_bug.cgi?id=230569
+
+ Reviewed by Yusuke Suzuki.
+
+ * assembler/ARM64Assembler.h:
+ * assembler/ARM64EAssembler.h:
+
2021-09-21 Justin Michaud <[email protected]>
Differential testing: live statement don't execute
Modified: trunk/Source/_javascript_Core/assembler/ARM64Assembler.h (282831 => 282832)
--- trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2021-09-21 18:30:37 UTC (rev 282831)
+++ trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2021-09-21 18:43:34 UTC (rev 282832)
@@ -41,8 +41,8 @@
#include <zircon/syscalls.h>
#endif
-#define CHECK_DATASIZE_OF(datasize) ASSERT(datasize == 32 || datasize == 64)
-#define CHECK_MEMOPSIZE_OF(size) ASSERT(size == 8 || size == 16 || size == 32 || size == 64 || size == 128);
+#define CHECK_DATASIZE_OF(datasize) static_assert(datasize == 32 || datasize == 64)
+#define CHECK_MEMOPSIZE_OF(size) static_assert(size == 8 || size == 16 || size == 32 || size == 64 || size == 128);
#define DATASIZE_OF(datasize) ((datasize == 64) ? Datasize_64 : Datasize_32)
#define MEMOPSIZE_OF(datasize) ((datasize == 8 || datasize == 128) ? MemOpSize_8_or_128 : (datasize == 16) ? MemOpSize_16 : (datasize == 32) ? MemOpSize_32 : MemOpSize_64)
#define CHECK_DATASIZE() CHECK_DATASIZE_OF(datasize)
@@ -3862,6 +3862,7 @@
} // namespace JSC
#undef CHECK_DATASIZE_OF
+#undef CHECK_MEMOPSIZE_OF
#undef DATASIZE_OF
#undef MEMOPSIZE_OF
#undef CHECK_DATASIZE
Modified: trunk/Source/_javascript_Core/assembler/ARM64EAssembler.h (282831 => 282832)
--- trunk/Source/_javascript_Core/assembler/ARM64EAssembler.h 2021-09-21 18:30:37 UTC (rev 282831)
+++ trunk/Source/_javascript_Core/assembler/ARM64EAssembler.h 2021-09-21 18:43:34 UTC (rev 282832)
@@ -31,7 +31,7 @@
namespace JSC {
-#define CHECK_MEMOPSIZE_OF(size) ASSERT(size == 8 || size == 16 || size == 32 || size == 64 || size == 128);
+#define CHECK_MEMOPSIZE_OF(size) static_assert(size == 8 || size == 16 || size == 32 || size == 64 || size == 128);
#define MEMOPSIZE_OF(datasize) ((datasize == 8 || datasize == 128) ? MemOpSize_8_or_128 : (datasize == 16) ? MemOpSize_16 : (datasize == 32) ? MemOpSize_32 : MemOpSize_64)
#define CHECK_MEMOPSIZE() CHECK_MEMOPSIZE_OF(datasize)
#define MEMOPSIZE MEMOPSIZE_OF(datasize)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
