Title: [282845] trunk/Source/WebKit
- Revision
- 282845
- Author
- [email protected]
- Date
- 2021-09-21 15:43:35 -0700 (Tue, 21 Sep 2021)
Log Message
Remove unused selection parameter.
https://bugs.webkit.org/show_bug.cgi?id=230519
Reviewed by Wenson Hsieh.
The direction of movement of the selection is not actually used to determine which direction to extend to a
word boundary, so do not pass it in. In preparation of being able to condense these enums into one.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeAtWordBoundaryForPosition):
(WebKit::WebPage::updateSelectionWithTouches):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (282844 => 282845)
--- trunk/Source/WebKit/ChangeLog 2021-09-21 22:13:24 UTC (rev 282844)
+++ trunk/Source/WebKit/ChangeLog 2021-09-21 22:43:35 UTC (rev 282845)
@@ -1,3 +1,17 @@
+2021-09-21 Megan Gardner <[email protected]>
+
+ Remove unused selection parameter.
+ https://bugs.webkit.org/show_bug.cgi?id=230519
+
+ Reviewed by Wenson Hsieh.
+
+ The direction of movement of the selection is not actually used to determine which direction to extend to a
+ word boundary, so do not pass it in. In preparation of being able to condense these enums into one.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::rangeAtWordBoundaryForPosition):
+ (WebKit::WebPage::updateSelectionWithTouches):
+
2021-09-21 David Kilzer <[email protected]>
Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (282844 => 282845)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2021-09-21 22:13:24 UTC (rev 282844)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2021-09-21 22:43:35 UTC (rev 282845)
@@ -1574,7 +1574,7 @@
return range;
}
-static std::optional<SimpleRange> rangeAtWordBoundaryForPosition(Frame* frame, const VisiblePosition& position, bool baseIsStart, SelectionDirection direction)
+static std::optional<SimpleRange> rangeAtWordBoundaryForPosition(Frame* frame, const VisiblePosition& position, bool baseIsStart)
{
SelectionDirection sameDirection = baseIsStart ? SelectionDirection::Forward : SelectionDirection::Backward;
SelectionDirection oppositeDirection = baseIsStart ? SelectionDirection::Backward : SelectionDirection::Forward;
@@ -1757,11 +1757,8 @@
break;
case SelectionTouch::EndedMovingForward:
- range = rangeAtWordBoundaryForPosition(frame.ptr(), position, baseIsStart, SelectionDirection::Forward);
- break;
-
case SelectionTouch::EndedMovingBackward:
- range = rangeAtWordBoundaryForPosition(frame.ptr(), position, baseIsStart, SelectionDirection::Backward);
+ range = rangeAtWordBoundaryForPosition(frame.ptr(), position, baseIsStart);
break;
case SelectionTouch::Moved:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
