Title: [282955] trunk/Source/WebCore
- Revision
- 282955
- Author
- [email protected]
- Date
- 2021-09-23 04:50:41 -0700 (Thu, 23 Sep 2021)
Log Message
Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
https://bugs.webkit.org/show_bug.cgi?id=230678
Reviewed by Antti Koivisto.
No behaviour change. The definition of isHidden is:
`bool isHidden() const override { return isAXHidden() || isDOMHidden(); }`
* inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (282954 => 282955)
--- trunk/Source/WebCore/ChangeLog 2021-09-23 09:54:21 UTC (rev 282954)
+++ trunk/Source/WebCore/ChangeLog 2021-09-23 11:50:41 UTC (rev 282955)
@@ -1,3 +1,19 @@
+2021-09-23 Tim Nguyen <[email protected]>
+
+ Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
+ https://bugs.webkit.org/show_bug.cgi?id=230678
+
+ Reviewed by Antti Koivisto.
+
+ No behaviour change. The definition of isHidden is:
+
+ `bool isHidden() const override { return isAXHidden() || isDOMHidden(); }`
+
+ * inspector/InspectorAuditAccessibilityObject.cpp:
+ (WebCore::InspectorAuditAccessibilityObject::getComputedProperties):
+ * inspector/agents/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+
2021-09-23 Jean-Yves Avenard <[email protected]>
Opus and Vorbis codecs aren't available on iPad.
Modified: trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp (282954 => 282955)
--- trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp 2021-09-23 09:54:21 UTC (rev 282954)
+++ trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp 2021-09-23 11:50:41 UTC (rev 282955)
@@ -175,7 +175,7 @@
computedProperties.focused = axObject->isFocused();
computedProperties.headingLevel = axObject->headingLevel();
- computedProperties.hidden = axObject->isAXHidden() || axObject->isDOMHidden();
+ computedProperties.hidden = axObject->isHidden();
computedProperties.hierarchicalLevel = axObject->hierarchicalLevel();
computedProperties.ignored = axObject->accessibilityIsIgnored();
computedProperties.ignoredByDefault = axObject->accessibilityIsIgnoredByDefault();
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp (282954 => 282955)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2021-09-23 09:54:21 UTC (rev 282954)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2021-09-23 11:50:41 UTC (rev 282955)
@@ -2117,7 +2117,7 @@
else // Future versions of ARIA may allow additional truthy values. Ex. format, order, or size.
invalid = Protocol::DOM::AccessibilityProperties::Invalid::True;
- if (axObject->isAXHidden() || axObject->isDOMHidden())
+ if (axObject->isHidden())
hidden = true;
label = axObject->computedLabel();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
