Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (106589 => 106590)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-02 21:49:50 UTC (rev 106590)
@@ -1,3 +1,101 @@
+2012-02-02 Filip Pizlo <[email protected]>
+
+ Release build debugging should be easier
+ https://bugs.webkit.org/show_bug.cgi?id=77669
+
+ Reviewed by Gavin Barraclough.
+
+ * assembler/ARMAssembler.h:
+ (ARMAssembler):
+ (JSC::ARMAssembler::debugOffset):
+ * assembler/ARMv7Assembler.h:
+ (ARMv7Assembler):
+ (JSC::ARMv7Assembler::debugOffset):
+ (ARMInstructionFormatter):
+ (JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
+ * assembler/AbstractMacroAssembler.h:
+ (AbstractMacroAssembler):
+ (JSC::AbstractMacroAssembler::debugOffset):
+ * assembler/AssemblerBuffer.h:
+ (AssemblerBuffer):
+ (JSC::AssemblerBuffer::debugOffset):
+ * assembler/LinkBuffer.h:
+ (LinkBuffer):
+ (JSC::LinkBuffer::debugSize):
+ * assembler/MIPSAssembler.h:
+ (MIPSAssembler):
+ (JSC::MIPSAssembler::debugOffset):
+ * assembler/X86Assembler.h:
+ (X86Assembler):
+ (JSC::X86Assembler::debugOffset):
+ (X86InstructionFormatter):
+ (JSC::X86Assembler::X86InstructionFormatter::debugOffset):
+ * bytecode/CodeBlock.cpp:
+ (JSC):
+ * bytecode/CodeBlock.h:
+ (CodeBlock):
+ * bytecode/CodeOrigin.h:
+ (CodeOrigin):
+ (JSC):
+ (JSC::CodeOrigin::inlineStack):
+ * bytecode/DFGExitProfile.h:
+ (JSC::DFG::exitKindToString):
+ * bytecode/DataFormat.h:
+ (JSC::dataFormatToString):
+ * bytecode/PredictedType.cpp:
+ (JSC):
+ (JSC::predictionToString):
+ * bytecode/PredictedType.h:
+ (JSC):
+ * bytecode/ValueRecovery.h:
+ (ValueRecovery):
+ (JSC::ValueRecovery::dump):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC):
+ (JSC::BytecodeGenerator::setDumpsGeneratedCode):
+ (JSC::BytecodeGenerator::dumpsGeneratedCode):
+ (JSC::BytecodeGenerator::generate):
+ * dfg/DFGAbstractValue.h:
+ (StructureAbstractValue):
+ (JSC::DFG::StructureAbstractValue::dump):
+ (AbstractValue):
+ (JSC::DFG::AbstractValue::dump):
+ * dfg/DFGAssemblyHelpers.h:
+ (DFG):
+ (AssemblyHelpers):
+ (JSC::DFG::AssemblyHelpers::debugCall):
+ * dfg/DFGFPRInfo.h:
+ (FPRInfo):
+ (JSC::DFG::FPRInfo::debugName):
+ * dfg/DFGGPRInfo.h:
+ (GPRInfo):
+ (JSC::DFG::GPRInfo::debugName):
+ * dfg/DFGGraph.cpp:
+ (DFG):
+ * dfg/DFGGraph.h:
+ (Graph):
+ * dfg/DFGNode.h:
+ (DFG):
+ (JSC::DFG::arithNodeFlagsAsString):
+ (Node):
+ (JSC::DFG::Node::hasIdentifier):
+ (JSC::DFG::Node::dumpChildren):
+ * dfg/DFGOSRExit.cpp:
+ (DFG):
+ (JSC::DFG::OSRExit::dump):
+ * dfg/DFGOSRExit.h:
+ (OSRExit):
+ * runtime/JSValue.cpp:
+ (JSC):
+ (JSC::JSValue::description):
+ * runtime/JSValue.h:
+ (JSValue):
+ * wtf/BitVector.cpp:
+ (WTF):
+ (WTF::BitVector::dump):
+ * wtf/BitVector.h:
+ (BitVector):
+
2012-02-02 Oliver Hunt <[email protected]>
Getters and setters cause line numbers in errors/console.log to be offset for the whole file
Modified: trunk/Source/_javascript_Core/assembler/ARMAssembler.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/ARMAssembler.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -681,9 +681,7 @@
PassRefPtr<ExecutableMemoryHandle> executableCopy(JSGlobalData&, void* ownerUID);
-#ifndef NDEBUG
unsigned debugOffset() { return m_buffer.debugOffset(); }
-#endif
// Patching helpers
Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -1991,9 +1991,7 @@
return reinterpret_cast<void*>(readInt32(where));
}
-#ifndef NDEBUG
unsigned debugOffset() { return m_formatter.debugOffset(); }
-#endif
private:
// VFP operations commonly take one or more 5-bit operands, typically representing a
@@ -2490,9 +2488,7 @@
bool isAligned(int alignment) const { return m_buffer.isAligned(alignment); }
void* data() const { return m_buffer.data(); }
-#ifndef NDEBUG
unsigned debugOffset() { return m_buffer.debugOffset(); }
-#endif
private:
AssemblerBuffer m_buffer;
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -538,9 +538,7 @@
void beginUninterruptedSequence() { }
void endUninterruptedSequence() { }
-#ifndef NDEBUG
unsigned debugOffset() { return m_assembler.debugOffset(); }
-#endif
protected:
AssemblerType m_assembler;
Modified: trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -146,9 +146,7 @@
return result.release();
}
-#ifndef NDEBUG
unsigned debugOffset() { return m_index; }
-#endif
protected:
void append(const char* data, int size)
Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/LinkBuffer.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/LinkBuffer.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -189,7 +189,6 @@
return CodePtr(MacroAssembler::AssemblerType_T::getRelocatedAddress(code(), applyOffset(label.m_label)));
}
-#ifndef NDEBUG
void* debugAddress()
{
return m_code;
@@ -199,7 +198,6 @@
{
return m_size;
}
-#endif
private:
template <typename T> T applyOffset(T src)
Modified: trunk/Source/_javascript_Core/assembler/MIPSAssembler.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -655,9 +655,7 @@
return result.release();
}
-#ifndef NDEBUG
unsigned debugOffset() { return m_buffer.debugOffset(); }
-#endif
static unsigned getCallReturnOffset(AssemblerLabel call)
{
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (106589 => 106590)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -1787,9 +1787,7 @@
return m_formatter.executableCopy(globalData, ownerUID);
}
-#ifndef NDEBUG
unsigned debugOffset() { return m_formatter.debugOffset(); }
-#endif
void nop()
{
@@ -2137,9 +2135,7 @@
return m_buffer.executableCopy(globalData, ownerUID);
}
-#ifndef NDEBUG
unsigned debugOffset() { return m_buffer.debugOffset(); }
-#endif
private:
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -59,8 +59,6 @@
using namespace DFG;
#endif
-#if !defined(NDEBUG) || ENABLE(OPCODE_SAMPLING)
-
static UString escapeQuotes(const UString& str)
{
UString result = str;
@@ -1286,8 +1284,6 @@
}
}
-#endif // !defined(NDEBUG) || ENABLE(OPCODE_SAMPLING)
-
#if DUMP_CODE_BLOCK_STATISTICS
static HashSet<CodeBlock*> liveCodeBlockSet;
#endif
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -134,11 +134,9 @@
static void dumpStatistics();
-#if !defined(NDEBUG) || ENABLE_OPCODE_SAMPLING
void dump(ExecState*) const;
void printStructures(const Instruction*) const;
void printStructure(const char* name, const Instruction*, int operand) const;
-#endif
bool isStrictMode() const { return m_isStrictMode; }
@@ -362,9 +360,7 @@
discardBytecodeLater();
}
-#ifndef NDEBUG
bool usesOpcode(OpcodeID);
-#endif
unsigned instructionCount() { return m_instructionCount; }
void setInstructionCount(unsigned instructionCount) { m_instructionCount = instructionCount; }
@@ -1016,7 +1012,6 @@
void tallyFrequentExitSites() { }
#endif
-#if !defined(NDEBUG) || ENABLE(OPCODE_SAMPLING)
void dump(ExecState*, const Vector<Instruction>::const_iterator& begin, Vector<Instruction>::const_iterator&) const;
CString registerName(ExecState*, int r) const;
@@ -1026,7 +1021,6 @@
void printGetByIdOp(ExecState*, int location, Vector<Instruction>::const_iterator&, const char* op) const;
void printCallOp(ExecState*, int location, Vector<Instruction>::const_iterator&, const char* op) const;
void printPutByIdOp(ExecState*, int location, Vector<Instruction>::const_iterator&, const char* op) const;
-#endif
void visitStructures(SlotVisitor&, Instruction* vPC) const;
#if ENABLE(DFG_JIT)
Modified: trunk/Source/_javascript_Core/bytecode/CodeOrigin.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/CodeOrigin.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/CodeOrigin.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -83,10 +83,8 @@
bool operator!=(const CodeOrigin& other) const { return !(*this == other); }
-#ifndef NDEBUG
// Get the inline stack. This is slow, and is intended for debugging only.
Vector<CodeOrigin> inlineStack() const;
-#endif
};
struct InlineCallFrame {
@@ -122,7 +120,6 @@
&& inlineCallFrame == other.inlineCallFrame;
}
-#ifndef NDEBUG
// Get the inline stack. This is slow, and is intended for debugging only.
inline Vector<CodeOrigin> CodeOrigin::inlineStack() const
{
@@ -133,7 +130,6 @@
result[index--] = current->caller;
return result;
}
-#endif
inline unsigned getCallReturnOffsetForCodeOrigin(CodeOriginAtCallReturnOffset* data)
{
Modified: trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -41,7 +41,6 @@
Uncountable, // We exited for none of the above reasons, and we should not count it. Most uses of this should be viewed as a FIXME.
};
-#ifndef NDEBUG
inline const char* exitKindToString(ExitKind kind)
{
switch (kind) {
@@ -59,7 +58,6 @@
return "Unknown";
}
}
-#endif
inline bool exitKindIsCountable(ExitKind kind)
{
Modified: trunk/Source/_javascript_Core/bytecode/DataFormat.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/DataFormat.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/DataFormat.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -50,7 +50,6 @@
DataFormatJSBoolean = DataFormatJS | DataFormatBoolean
};
-#ifndef NDEBUG
inline const char* dataFormatToString(DataFormat dataFormat)
{
switch (dataFormat) {
@@ -80,7 +79,6 @@
return "Unknown";
}
}
-#endif
#if USE(JSVALUE64)
inline bool needDataFormatConversion(DataFormat from, DataFormat to)
Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/PredictedType.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -36,7 +36,6 @@
namespace JSC {
-#ifndef NDEBUG
const char* predictionToString(PredictedType value)
{
if (value == PredictNone)
@@ -160,7 +159,6 @@
return description;
}
-#endif
PredictedType predictionFromClassInfo(const ClassInfo* classInfo)
{
Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/PredictedType.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -217,9 +217,7 @@
return value == PredictOther;
}
-#ifndef NDEBUG
const char* predictionToString(PredictedType value);
-#endif
// Merge two predictions. Note that currently this just does left | right. It may
// seem tempting to do so directly, but you would be doing so at your own peril,
Modified: trunk/Source/_javascript_Core/bytecode/ValueRecovery.h (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -30,12 +30,9 @@
#include "JSValue.h"
#include "MacroAssembler.h"
#include "VirtualRegister.h"
+#include <stdio.h>
#include <wtf/Platform.h>
-#ifndef NDEBUG
-#include <stdio.h>
-#endif
-
namespace JSC {
// Describes how to recover a given bytecode virtual register at a given
@@ -249,7 +246,6 @@
return JSValue::decode(m_source.constant);
}
-#ifndef NDEBUG
void dump(FILE* out) const
{
switch (technique()) {
@@ -314,7 +310,6 @@
break;
}
}
-#endif
private:
ValueRecoveryTechnique m_technique;
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -150,26 +150,16 @@
}
#endif
-#ifndef NDEBUG
static bool s_dumpsGeneratedCode = false;
-#endif
void BytecodeGenerator::setDumpsGeneratedCode(bool dumpsGeneratedCode)
{
-#ifndef NDEBUG
s_dumpsGeneratedCode = dumpsGeneratedCode;
-#else
- UNUSED_PARAM(dumpsGeneratedCode);
-#endif
}
bool BytecodeGenerator::dumpsGeneratedCode()
{
-#ifndef NDEBUG
return s_dumpsGeneratedCode;
-#else
- return false;
-#endif
}
JSObject* BytecodeGenerator::generate()
@@ -182,10 +172,8 @@
m_codeBlock->setInstructionCount(m_codeBlock->instructions().size());
-#ifndef NDEBUG
if (s_dumpsGeneratedCode)
m_codeBlock->dump(m_scopeChain->globalObject->globalExec());
-#endif
if ((m_codeType == FunctionCode && !m_codeBlock->needsFullScopeChain() && !m_codeBlock->usesArguments()) || m_codeType == EvalCode)
symbolTable().clear();
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -287,7 +287,6 @@
return m_structure == other.m_structure;
}
-#ifndef NDEBUG
void dump(FILE* out) const
{
if (isTop()) {
@@ -300,7 +299,6 @@
fprintf(out, "%p", m_structure);
fprintf(out, "]");
}
-#endif
private:
static Structure* topValue() { return reinterpret_cast<Structure*>(1); }
@@ -466,14 +464,12 @@
// complexity of the code.
}
-#ifndef NDEBUG
void dump(FILE* out) const
{
fprintf(out, "(%s, ", predictionToString(m_type));
m_structure.dump(out);
fprintf(out, ")");
}
-#endif
StructureAbstractValue m_structure;
PredictedType m_type;
Modified: trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -39,9 +39,7 @@
namespace JSC { namespace DFG {
-#ifndef NDEBUG
typedef void (*V_DFGDebugOperation_EP)(ExecState*, void*);
-#endif
class AssemblyHelpers : public MacroAssembler {
public:
@@ -152,7 +150,6 @@
return branch8(Below, Address(structureReg, Structure::typeInfoTypeOffset()), TrustedImm32(ObjectType));
}
-#ifndef NDEBUG
// Add a debug call. This call has no effect on JIT code execution state.
void debugCall(V_DFGDebugOperation_EP function, void* argument)
{
@@ -182,7 +179,6 @@
for (unsigned i = 0; i < GPRInfo::numberOfRegisters; ++i)
loadPtr(buffer + i, GPRInfo::toRegister(i));
}
-#endif
// These methods JIT generate dynamic, debug-only checks - akin to ASSERTs.
#if DFG_ENABLE(JIT_ASSERT)
Modified: trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGFPRInfo.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -78,7 +78,6 @@
return (unsigned)reg;
}
-#ifndef NDEBUG
static const char* debugName(FPRReg reg)
{
ASSERT(reg != InvalidFPRReg);
@@ -99,7 +98,6 @@
#endif
return nameForRegister[reg];
}
-#endif
};
#endif
@@ -141,7 +139,6 @@
return (unsigned)reg;
}
-#ifndef NDEBUG
static const char* debugName(FPRReg reg)
{
ASSERT(reg != InvalidFPRReg);
@@ -158,7 +155,6 @@
};
return nameForRegister[reg];
}
-#endif
};
#endif
Modified: trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -292,7 +292,6 @@
return result;
}
-#ifndef NDEBUG
static const char* debugName(GPRReg reg)
{
ASSERT(reg != InvalidGPRReg);
@@ -303,7 +302,6 @@
};
return nameForRegister[reg];
}
-#endif
private:
static const unsigned InvalidIndex = 0xffffffff;
@@ -363,7 +361,6 @@
return result;
}
-#ifndef NDEBUG
static const char* debugName(GPRReg reg)
{
ASSERT(reg != InvalidGPRReg);
@@ -376,7 +373,6 @@
};
return nameForRegister[reg];
}
-#endif
private:
static const unsigned InvalidIndex = 0xffffffff;
@@ -436,7 +432,6 @@
return result;
}
-#ifndef NDEBUG
static const char* debugName(GPRReg reg)
{
ASSERT(reg != InvalidGPRReg);
@@ -449,7 +444,6 @@
};
return nameForRegister[reg];
}
-#endif
private:
static const unsigned InvalidIndex = 0xffffffff;
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -32,8 +32,6 @@
namespace JSC { namespace DFG {
-#ifndef NDEBUG
-
// Creates an array of stringized names.
static const char* dfgOpNames[] = {
#define STRINGIZE_DFG_OP_ENUM(opcode, flags) #opcode ,
@@ -298,8 +296,6 @@
dump(i, codeBlock);
}
-#endif
-
// FIXME: Convert this to be iterative, not recursive.
#define DO_TO_CHILDREN(node, thingToDo) do { \
Node& _node = (node); \
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -110,7 +110,6 @@
node.children.fixed.child3 = NoNode;
}
-#ifndef NDEBUG
// CodeBlock is optional, but may allow additional information to be dumped (e.g. Identifier names).
void dump(CodeBlock* = 0);
void dump(NodeIndex, CodeBlock* = 0);
@@ -118,7 +117,6 @@
// Dump the code origin of the given node as a diff from the code origin of the
// preceding node.
void dumpCodeOrigin(NodeIndex);
-#endif
BlockIndex blockIndexForBytecodeOffset(Vector<BlockIndex>& blocks, unsigned bytecodeBegin);
@@ -214,12 +212,10 @@
return asFunction(function);
}
-#ifndef NDEBUG
static const char *opName(NodeType);
// This is O(n), and should only be used for verbose dumps.
const char* nameOfVariableAccessData(VariableAccessData*);
-#endif
void predictArgumentTypes(CodeBlock*);
Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGNode.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -96,7 +96,6 @@
return true;
}
-#ifndef NDEBUG
static inline const char* arithNodeFlagsAsString(ArithNodeFlags flags)
{
if (!flags)
@@ -138,7 +137,6 @@
return description;
}
-#endif
// Entries in the NodeType enum (below) are composed of an id, a result type (possibly none)
// and some additional informative flags (must generate, is constant, etc).
@@ -499,7 +497,6 @@
return variableAccessData()->local();
}
-#ifndef NDEBUG
bool hasIdentifier()
{
switch (op) {
@@ -515,7 +512,6 @@
return false;
}
}
-#endif
unsigned identifierNumber()
{
@@ -1036,7 +1032,6 @@
return nodeCanSpeculateInteger(arithNodeFlags());
}
-#ifndef NDEBUG
void dumpChildren(FILE* out)
{
if (child1() == NoNode)
@@ -1049,7 +1044,6 @@
return;
fprintf(out, ", @%u", child3());
}
-#endif
// This enum value describes the type of the node.
NodeType op;
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -53,7 +53,6 @@
m_variables[variable] = jit->computeValueRecoveryFor(jit->m_variables[variable]);
}
-#ifndef NDEBUG
void OSRExit::dump(FILE* out) const
{
for (unsigned argument = 0; argument < m_arguments.size(); ++argument)
@@ -62,7 +61,6 @@
for (unsigned variable = 0; variable < m_variables.size(); ++variable)
m_variables[variable].dump(out);
}
-#endif
bool OSRExit::considerAddingAsFrequentExitSiteSlow(CodeBlock* dfgCodeBlock, CodeBlock* profiledCodeBlock)
{
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRExit.h (106589 => 106590)
--- trunk/Source/_javascript_Core/dfg/DFGOSRExit.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRExit.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -137,9 +137,7 @@
return considerAddingAsFrequentExitSiteSlow(dfgCodeBlock, profiledCodeBlock);
}
-#ifndef NDEBUG
void dump(FILE* out) const;
-#endif
Vector<ValueRecovery, 0> m_arguments;
Vector<ValueRecovery, 0> m_variables;
Modified: trunk/Source/_javascript_Core/runtime/JSValue.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/runtime/JSValue.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/runtime/JSValue.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -116,7 +116,6 @@
return JSNotAnObject::create(exec);
}
-#ifndef NDEBUG
char* JSValue::description()
{
static const size_t size = 64;
@@ -152,7 +151,6 @@
return description;
}
-#endif
// This in the ToInt32 operation is defined in section 9.5 of the ECMA-262 spec.
// Note that this operation is identical to ToUInt32 other than to interpretation
Modified: trunk/Source/_javascript_Core/runtime/JSValue.h (106589 => 106590)
--- trunk/Source/_javascript_Core/runtime/JSValue.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/runtime/JSValue.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -232,9 +232,7 @@
JSCell* asCell() const;
JS_EXPORT_PRIVATE bool isValidCallee();
-#ifndef NDEBUG
char* description();
-#endif
private:
template <class T> JSValue(WriteBarrierBase<T>);
Modified: trunk/Source/_javascript_Core/wtf/BitVector.cpp (106589 => 106590)
--- trunk/Source/_javascript_Core/wtf/BitVector.cpp 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/wtf/BitVector.cpp 2012-02-02 21:49:50 UTC (rev 106590)
@@ -105,7 +105,6 @@
m_bitsOrPointer = bitwise_cast<uintptr_t>(newOutOfLineBits) >> 1;
}
-#ifndef NDEBUG
void BitVector::dump(FILE* out)
{
for (size_t i = 0; i < size(); ++i) {
@@ -115,6 +114,5 @@
fprintf(out, "-");
}
}
-#endif
} // namespace WTF
Modified: trunk/Source/_javascript_Core/wtf/BitVector.h (106589 => 106590)
--- trunk/Source/_javascript_Core/wtf/BitVector.h 2012-02-02 21:19:53 UTC (rev 106589)
+++ trunk/Source/_javascript_Core/wtf/BitVector.h 2012-02-02 21:49:50 UTC (rev 106590)
@@ -26,13 +26,10 @@
#ifndef BitVector_h
#define BitVector_h
+#include <stdio.h>
#include <wtf/Assertions.h>
#include <wtf/StdLibExtras.h>
-#ifndef NDEBUG
-#include <stdio.h>
-#endif
-
namespace WTF {
// This is a space-efficient, resizeable bitvector class. In the common case it
@@ -165,9 +162,7 @@
clear(bit);
}
-#ifndef NDEBUG
void dump(FILE* out);
-#endif
private:
static unsigned bitsInPointer()
