Title: [283134] trunk/Source/WebCore
- Revision
- 283134
- Author
- [email protected]
- Date
- 2021-09-27 14:21:37 -0700 (Mon, 27 Sep 2021)
Log Message
Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolutionCallback
https://bugs.webkit.org/show_bug.cgi?id=230851
Reviewed by Simon Fraser.
The HTML5 event loop should be used instead.
Also fix pre-existing webkit-style errors.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::didAttachRenderers):
(WebCore::HTMLFormControlElement::didRecalcStyle):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::scheduleInvalidateStyleAndLayerComposition):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::scheduleUpdateForAfterStyleResolution):
* style/StyleTreeResolver.cpp:
(WebCore::Style::deprecatedQueuePostResolutionCallback):
(WebCore::Style::queuePostResolutionCallback): Deleted.
* style/StyleTreeResolver.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283133 => 283134)
--- trunk/Source/WebCore/ChangeLog 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/ChangeLog 2021-09-27 21:21:37 UTC (rev 283134)
@@ -1,3 +1,25 @@
+2021-09-27 Tim Nguyen <[email protected]>
+
+ Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolutionCallback
+ https://bugs.webkit.org/show_bug.cgi?id=230851
+
+ Reviewed by Simon Fraser.
+
+ The HTML5 event loop should be used instead.
+ Also fix pre-existing webkit-style errors.
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::didAttachRenderers):
+ (WebCore::HTMLFormControlElement::didRecalcStyle):
+ * html/HTMLFrameOwnerElement.cpp:
+ (WebCore::HTMLFrameOwnerElement::scheduleInvalidateStyleAndLayerComposition):
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::scheduleUpdateForAfterStyleResolution):
+ * style/StyleTreeResolver.cpp:
+ (WebCore::Style::deprecatedQueuePostResolutionCallback):
+ (WebCore::Style::queuePostResolutionCallback): Deleted.
+ * style/StyleTreeResolver.h:
+
2021-09-27 Myles C. Maxfield <[email protected]>
The CSS Fonts spec has deleted CSSRule.FONT_PALETTE_VALUES_RULE
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (283133 => 283134)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2021-09-27 21:21:37 UTC (rev 283134)
@@ -258,7 +258,7 @@
element->focus({ SelectionRestorationMode::PlaceCaretAtStart });
});
} else {
- Style::queuePostResolutionCallback([element] {
+ Style::deprecatedQueuePostResolutionCallback([element] {
element->focus({ SelectionRestorationMode::PlaceCaretAtStart });
});
}
@@ -366,7 +366,7 @@
// trigger synchronous layout, so it must not be called during style recalc.
if (renderer()) {
RefPtr<HTMLFormControlElement> element = this;
- Style::queuePostResolutionCallback([element]{
+ Style::deprecatedQueuePostResolutionCallback([element] {
if (auto* renderer = element->renderer())
renderer->updateFromElement();
});
Modified: trunk/Source/WebCore/html/HTMLFrameOwnerElement.cpp (283133 => 283134)
--- trunk/Source/WebCore/html/HTMLFrameOwnerElement.cpp 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/html/HTMLFrameOwnerElement.cpp 2021-09-27 21:21:37 UTC (rev 283134)
@@ -120,7 +120,7 @@
{
if (Style::postResolutionCallbacksAreSuspended()) {
RefPtr<HTMLFrameOwnerElement> element = this;
- Style::queuePostResolutionCallback([element] {
+ Style::deprecatedQueuePostResolutionCallback([element] {
element->invalidateStyleAndLayerComposition();
});
} else
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (283133 => 283134)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2021-09-27 21:21:37 UTC (rev 283134)
@@ -195,7 +195,7 @@
m_hasUpdateScheduledForAfterStyleResolution = true;
- Style::queuePostResolutionCallback([protectedThis = Ref { *this }] {
+ Style::deprecatedQueuePostResolutionCallback([protectedThis = Ref { *this }] {
protectedThis->updateAfterStyleResolution();
});
}
Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (283133 => 283134)
--- trunk/Source/WebCore/style/StyleTreeResolver.cpp 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp 2021-09-27 21:21:37 UTC (rev 283134)
@@ -648,7 +648,7 @@
return vector;
}
-void queuePostResolutionCallback(Function<void ()>&& callback)
+void deprecatedQueuePostResolutionCallback(Function<void()>&& callback)
{
postResolutionCallbackQueue().append(WTFMove(callback));
}
Modified: trunk/Source/WebCore/style/StyleTreeResolver.h (283133 => 283134)
--- trunk/Source/WebCore/style/StyleTreeResolver.h 2021-09-27 21:07:19 UTC (rev 283133)
+++ trunk/Source/WebCore/style/StyleTreeResolver.h 2021-09-27 21:21:37 UTC (rev 283134)
@@ -112,7 +112,8 @@
std::unique_ptr<Update> m_update;
};
-void queuePostResolutionCallback(Function<void ()>&&);
+// Integrate with the HTML5 event loop instead, see EventLoop.cpp and consumers.
+void deprecatedQueuePostResolutionCallback(Function<void()>&&);
bool postResolutionCallbacksAreSuspended();
class PostResolutionCallbackDisabler {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
