Log Message
Add support for CSSFontPaletteValuesRule.name https://bugs.webkit.org/show_bug.cgi?id=230787 <rdar://problem/83528540>
Reviewed by Tim Horton. LayoutTests/imported/w3c: This is being upstreamed in https://github.com/web-platform-tests/wpt/pull/30960. * web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html: Source/WebCore: This was added to the CSS spec in https://github.com/w3c/csswg-drafts/commit/8868476c571d63b7f3f2718e22601a711a2d8683. Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html * css/CSSFontPaletteValuesRule.cpp: (WebCore::CSSFontPaletteValuesRule::name const): * css/CSSFontPaletteValuesRule.h: * css/CSSFontPaletteValuesRule.idl:
Modified Paths
- trunk/LayoutTests/imported/w3c/ChangeLog
- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
- trunk/Source/WebCore/ChangeLog
- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp
- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h
- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283139 => 283140)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-27 22:19:30 UTC (rev 283140)
@@ -1,5 +1,17 @@
2021-09-27 Myles C. Maxfield <[email protected]>
+ Add support for CSSFontPaletteValuesRule.name
+ https://bugs.webkit.org/show_bug.cgi?id=230787
+ <rdar://problem/83528540>
+
+ Reviewed by Tim Horton.
+
+ This is being upstreamed in https://github.com/web-platform-tests/wpt/pull/30960.
+
+ * web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
+
+2021-09-27 Myles C. Maxfield <[email protected]>
+
The CSS Fonts spec has deleted CSSRule.FONT_PALETTE_VALUES_RULE
https://bugs.webkit.org/show_bug.cgi?id=230786
<rdar://problem/83528219>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html (283139 => 283140)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html 2021-09-27 22:19:30 UTC (rev 283140)
@@ -118,6 +118,7 @@
test(function() {
let rule = rules[0];
assert_equals(rule.constructor.name, "CSSFontPaletteValuesRule");
+ assert_equals(rule.name, "A");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 0);
@@ -130,6 +131,7 @@
test(function() {
let rule = rules[1];
+ assert_equals(rule.name, "B");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 0);
@@ -149,6 +151,7 @@
test(function() {
let rule = rules[2];
+ assert_equals(rule.name, "C");
assert_equals(rule.fontFamily, "bar");
assert_equals(rule.basePalette, "2");
assert_equals(rule.size, 0);
@@ -166,6 +169,7 @@
test(function() {
let rule = rules[3];
+ assert_equals(rule.name, "D");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "bar");
assert_equals(rule.size, 1);
@@ -181,6 +185,7 @@
test(function() {
let rule = rules[4];
+ assert_equals(rule.name, "E");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -195,6 +200,7 @@
test(function() {
let rule = rules[5];
+ assert_equals(rule.name, "F");
assert_equals(rule.fontFamily, "foo");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 0);
@@ -208,6 +214,7 @@
test(function() {
let rule = rules[6];
+ assert_equals(rule.name, "G");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 2);
@@ -224,6 +231,7 @@
test(function() {
let rule = rules[7];
+ assert_equals(rule.name, "H");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -239,6 +247,7 @@
test(function() {
let rule = rules[8];
+ assert_equals(rule.name, "I");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "-3");
assert_equals(rule.size, 0);
@@ -251,6 +260,7 @@
test(function() {
let rule = rules[9];
+ assert_equals(rule.name, "J");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -266,6 +276,7 @@
test(function() {
let rule = rules[10];
+ assert_equals(rule.name, "K");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -280,6 +291,7 @@
test(function() {
let rule = rules[11];
+ assert_equals(rule.name, "L");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -294,6 +306,7 @@
test(function() {
let rule = rules[12];
+ assert_equals(rule.name, "M");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -308,6 +321,7 @@
test(function() {
let rule = rules[13];
+ assert_equals(rule.name, "N");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -322,6 +336,7 @@
test(function() {
let rule = rules[14];
+ assert_equals(rule.name, "O");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
@@ -336,6 +351,7 @@
test(function() {
let rule = rules[15];
+ assert_equals(rule.name, "P");
assert_equals(rule.fontFamily, "");
assert_equals(rule.basePalette, "");
assert_equals(rule.size, 1);
Modified: trunk/Source/WebCore/ChangeLog (283139 => 283140)
--- trunk/Source/WebCore/ChangeLog 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/Source/WebCore/ChangeLog 2021-09-27 22:19:30 UTC (rev 283140)
@@ -1,3 +1,21 @@
+2021-09-27 Myles C. Maxfield <[email protected]>
+
+ Add support for CSSFontPaletteValuesRule.name
+ https://bugs.webkit.org/show_bug.cgi?id=230787
+ <rdar://problem/83528540>
+
+ Reviewed by Tim Horton.
+
+ This was added to the CSS spec in
+ https://github.com/w3c/csswg-drafts/commit/8868476c571d63b7f3f2718e22601a711a2d8683.
+
+ Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
+
+ * css/CSSFontPaletteValuesRule.cpp:
+ (WebCore::CSSFontPaletteValuesRule::name const):
+ * css/CSSFontPaletteValuesRule.h:
+ * css/CSSFontPaletteValuesRule.idl:
+
2021-09-27 Takashi Komori <[email protected]>
[Curl] Set CURL_LOCK_DATA_SSL_SESSION option to reduce SSL/TLS handshake time
Modified: trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp (283139 => 283140)
--- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp 2021-09-27 22:19:30 UTC (rev 283140)
@@ -46,6 +46,11 @@
{
}
+String CSSFontPaletteValuesRule::name() const
+{
+ return m_fontPaletteValuesRule->name();
+}
+
String CSSFontPaletteValuesRule::fontFamily() const
{
return m_fontPaletteValuesRule->fontFamily();
Modified: trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h (283139 => 283140)
--- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h 2021-09-27 22:19:30 UTC (rev 283140)
@@ -42,6 +42,7 @@
virtual ~CSSFontPaletteValuesRule();
+ String name() const;
String fontFamily() const;
String basePalette() const;
Modified: trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl (283139 => 283140)
--- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl 2021-09-27 21:53:19 UTC (rev 283139)
+++ trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl 2021-09-27 22:19:30 UTC (rev 283140)
@@ -23,6 +23,7 @@
Exposed=Window
] interface CSSFontPaletteValuesRule : CSSRule {
readonly maplike<unsigned long, CSSOMString>;
+ readonly attribute CSSOMString name;
readonly attribute CSSOMString fontFamily;
readonly attribute CSSOMString basePalette;
};
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
