Title: [283197] trunk/Source/WebCore
- Revision
- 283197
- Author
- [email protected]
- Date
- 2021-09-28 15:03:46 -0700 (Tue, 28 Sep 2021)
Log Message
Negative integers in @font-palette-values are invalid
https://bugs.webkit.org/show_bug.cgi?id=230788
Reviewed by Simon Fraser.
<rdar://problem/83528806>
Addressing post-commit review.
No new tests because there is no behavior change.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::addAttributesForFontPalettes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283196 => 283197)
--- trunk/Source/WebCore/ChangeLog 2021-09-28 21:28:07 UTC (rev 283196)
+++ trunk/Source/WebCore/ChangeLog 2021-09-28 22:03:46 UTC (rev 283197)
@@ -1,3 +1,18 @@
+2021-09-28 Myles C. Maxfield <[email protected]>
+
+ Negative integers in @font-palette-values are invalid
+ https://bugs.webkit.org/show_bug.cgi?id=230788
+
+ Reviewed by Simon Fraser.
+ <rdar://problem/83528806>
+
+ Addressing post-commit review.
+
+ No new tests because there is no behavior change.
+
+ * platform/graphics/cocoa/FontCacheCoreText.cpp:
+ (WebCore::addAttributesForFontPalettes):
+
2021-09-28 Cameron McCormack <[email protected]>
Preserve color space when structured cloning ImageBitmaps
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (283196 => 283197)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2021-09-28 21:28:07 UTC (rev 283196)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2021-09-28 22:03:46 UTC (rev 283197)
@@ -452,13 +452,13 @@
case FontPalette::Type::Normal:
break;
case FontPalette::Type::Light: {
- auto light = kCTFontPaletteLight;
+ CFIndex light = kCTFontPaletteLight;
auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberCFIndexType, &light));
CFDictionaryAddValue(attributes, kCTFontPaletteAttribute, number.get());
break;
}
case FontPalette::Type::Dark: {
- auto dark = kCTFontPaletteDark;
+ CFIndex dark = kCTFontPaletteDark;
auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberCFIndexType, &dark));
CFDictionaryAddValue(attributes, kCTFontPaletteAttribute, number.get());
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
