Title: [283282] trunk/Tools
- Revision
- 283282
- Author
- [email protected]
- Date
- 2021-09-29 16:53:31 -0700 (Wed, 29 Sep 2021)
Log Message
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
https://bugs.webkit.org/show_bug.cgi?id=230995
Reviewed by Jonathan Bedard.
LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
in the framework.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (283281 => 283282)
--- trunk/Tools/ChangeLog 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/ChangeLog 2021-09-29 23:53:31 UTC (rev 283282)
@@ -1,3 +1,16 @@
+2021-09-29 Basuke Suzuki <[email protected]>
+
+ [webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
+ https://bugs.webkit.org/show_bug.cgi?id=230995
+
+ Reviewed by Jonathan Bedard.
+
+ LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
+ in the framework.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_identifier_name_in_declaration):
+
2021-09-29 Alex Christensen <[email protected]>
Update PCM Daemon name
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (283281 => 283282)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:53:31 UTC (rev 283282)
@@ -4104,6 +4104,7 @@
and not modified_identifier == "const_iterator"
and not modified_identifier == "vm_throw"
and not modified_identifier == "DFG_OPERATION"
+ and not modified_identifier == "LOG_CHANNEL"
and not modified_identifier.find('chrono_literals') >= 0):
error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
