Title: [283395] trunk/LayoutTests
- Revision
- 283395
- Author
- [email protected]
- Date
- 2021-10-01 13:32:43 -0700 (Fri, 01 Oct 2021)
Log Message
Fix flaky test: fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html
https://bugs.webkit.org/show_bug.cgi?id=231093
Reviewed by Alan Bujtas.
This test dumped overlay scrollbar state, but that state is timing-dependent since
AppKit changes it via animations. Rather than printing the full state, just
print the expanded and enabled states, since those are the states necessary for
the test to pass.
* fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered-expected.txt:
* fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (283394 => 283395)
--- trunk/LayoutTests/ChangeLog 2021-10-01 20:32:42 UTC (rev 283394)
+++ trunk/LayoutTests/ChangeLog 2021-10-01 20:32:43 UTC (rev 283395)
@@ -1,3 +1,18 @@
+2021-10-01 Simon Fraser <[email protected]>
+
+ Fix flaky test: fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html
+ https://bugs.webkit.org/show_bug.cgi?id=231093
+
+ Reviewed by Alan Bujtas.
+
+ This test dumped overlay scrollbar state, but that state is timing-dependent since
+ AppKit changes it via animations. Rather than printing the full state, just
+ print the expanded and enabled states, since those are the states necessary for
+ the test to pass.
+
+ * fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered-expected.txt:
+ * fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html:
+
2021-10-01 Ayumi Kojima <[email protected]>
Regression (r282210/r282211): [ macOS wk2 ] css3/filters/blur-various-radii.html is a flaky image failure.
Modified: trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered-expected.txt (283394 => 283395)
--- trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered-expected.txt 2021-10-01 20:32:42 UTC (rev 283394)
+++ trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered-expected.txt 2021-10-01 20:32:43 UTC (rev 283395)
@@ -6,7 +6,7 @@
Initial state
enabled
Hovering vertical scrollbar should show expanded scrollbar
-PASS Scrollbar state: enabled,expanded,visible_track,visible_thumb
+PASS Scrollbar is enabled and expanded
Unhovering vertical scrollbar should hide it
PASS Thumb and track hidden
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html (283394 => 283395)
--- trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html 2021-10-01 20:32:42 UTC (rev 283394)
+++ trunk/LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html 2021-10-01 20:32:43 UTC (rev 283395)
@@ -46,9 +46,10 @@
await UIHelper.mouseWheelScrollAt(x, y);
await UIHelper.waitForCondition(() => {
let state = internals.verticalScrollbarState(scroller);
+ let enabled = state.indexOf('enabled') != -1;
let expanded = state.indexOf('expanded') != -1;
- if (expanded)
- testPassed('Scrollbar state: ' + state);
+ if (enabled && expanded)
+ testPassed('Scrollbar is enabled and expanded');
return expanded;
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
