Title: [283445] trunk/Source/_javascript_Core
Revision
283445
Author
[email protected]
Date
2021-10-02 13:30:11 -0700 (Sat, 02 Oct 2021)

Log Message

[JSC] Enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build
https://bugs.webkit.org/show_bug.cgi?id=231120

Reviewed by Ross Kirsling.

We now assume that ICU is 64.2 or later in Darwin since Mojave WebKit build is no longer supported.
We enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build.

* runtime/IntlDateTimeFormat.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (283444 => 283445)


--- trunk/Source/_javascript_Core/ChangeLog	2021-10-02 19:15:28 UTC (rev 283444)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-02 20:30:11 UTC (rev 283445)
@@ -1,5 +1,17 @@
 2021-10-02  Yusuke Suzuki  <[email protected]>
 
+        [JSC] Enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build
+        https://bugs.webkit.org/show_bug.cgi?id=231120
+
+        Reviewed by Ross Kirsling.
+
+        We now assume that ICU is 64.2 or later in Darwin since Mojave WebKit build is no longer supported.
+        We enable HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS on Darwin OSS build.
+
+        * runtime/IntlDateTimeFormat.h:
+
+2021-10-02  Yusuke Suzuki  <[email protected]>
+
         Remove JSC hack after r283410
         https://bugs.webkit.org/show_bug.cgi?id=230261
 

Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h (283444 => 283445)


--- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h	2021-10-02 19:15:28 UTC (rev 283444)
+++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h	2021-10-02 20:30:11 UTC (rev 283445)
@@ -33,8 +33,7 @@
 struct UDateIntervalFormat;
 
 #if !defined(HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS)
-// ICU header is up-to-date if the build is non-Darwin or using Apple Internal SDK.
-#if (USE(APPLE_INTERNAL_SDK) || !OS(DARWIN)) && U_ICU_VERSION_MAJOR_NUM >= 64
+#if U_ICU_VERSION_MAJOR_NUM >= 64
 #define HAVE_ICU_U_DATE_INTERVAL_FORMAT_FORMAT_RANGE_TO_PARTS 1
 #endif
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to