Title: [283484] trunk/Source/WebCore
- Revision
- 283484
- Author
- wei...@apple.com
- Date
- 2021-10-03 16:09:02 -0700 (Sun, 03 Oct 2021)
Log Message
WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
https://bugs.webkit.org/show_bug.cgi?id=231144
Reviewed by Dean Jackson.
The m_environmentBlendMode and m_interactionMode members of WebXRSession were
not being initialized to anything and therefor were giving random data. This
is not really testable, as the result is just that the tests no longer flake.
* Modules/webxr/WebXRSession.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283483 => 283484)
--- trunk/Source/WebCore/ChangeLog 2021-10-03 23:03:35 UTC (rev 283483)
+++ trunk/Source/WebCore/ChangeLog 2021-10-03 23:09:02 UTC (rev 283484)
@@ -1,3 +1,16 @@
+2021-10-03 Sam Weinig <wei...@apple.com>
+
+ WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
+ https://bugs.webkit.org/show_bug.cgi?id=231144
+
+ Reviewed by Dean Jackson.
+
+ The m_environmentBlendMode and m_interactionMode members of WebXRSession were
+ not being initialized to anything and therefor were giving random data. This
+ is not really testable, as the result is just that the tests no longer flake.
+
+ * Modules/webxr/WebXRSession.h:
+
2021-10-03 David Kilzer <ddkil...@apple.com>
Build fix: Attribute IOSurfaces created by camera and decoders to responsible WebProcess
Modified: trunk/Source/WebCore/Modules/webxr/WebXRSession.h (283483 => 283484)
--- trunk/Source/WebCore/Modules/webxr/WebXRSession.h 2021-10-03 23:03:35 UTC (rev 283483)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSession.h 2021-10-03 23:09:02 UTC (rev 283484)
@@ -126,8 +126,8 @@
void onFrame(PlatformXR::Device::FrameData&&);
void applyPendingRenderState();
- XREnvironmentBlendMode m_environmentBlendMode;
- XRInteractionMode m_interactionMode;
+ XREnvironmentBlendMode m_environmentBlendMode { XREnvironmentBlendMode::Opaque };
+ XRInteractionMode m_interactionMode { XRInteractionMode::WorldSpace };
XRVisibilityState m_visibilityState { XRVisibilityState::Visible };
UniqueRef<WebXRInputSourceArray> m_inputSources;
bool m_ended { false };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
