Title: [283487] trunk/Source/WebKit
Revision
283487
Author
[email protected]
Date
2021-10-03 22:37:08 -0700 (Sun, 03 Oct 2021)

Log Message

[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
https://bugs.webkit.org/show_bug.cgi?id=231153

Reviewed by Alexey Proskuryakov.

Revert back to the previous NOP behavior of bindAccessibilityTree()
for GTK4, leaving the assert for the debug mode with an informative
message in the log.

Covered by existing tests.

* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (283486 => 283487)


--- trunk/Source/WebKit/ChangeLog	2021-10-04 04:34:43 UTC (rev 283486)
+++ trunk/Source/WebKit/ChangeLog	2021-10-04 05:37:08 UTC (rev 283487)
@@ -1,3 +1,19 @@
+2021-10-03  Lauro Moura  <[email protected]>
+
+        [GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
+        https://bugs.webkit.org/show_bug.cgi?id=231153
+
+        Reviewed by Alexey Proskuryakov.
+
+        Revert back to the previous NOP behavior of bindAccessibilityTree()
+        for GTK4, leaving the assert for the debug mode with an informative
+        message in the log.
+
+        Covered by existing tests.
+
+        * UIProcess/gtk/WebPageProxyGtk.cpp:
+        (WebKit::WebPageProxy::bindAccessibilityTree):
+
 2021-10-03  Don Olmstead  <[email protected]>
 
         Non-unified build fixes, early October 2021 edition

Modified: trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp (283486 => 283487)


--- trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp	2021-10-04 04:34:43 UTC (rev 283486)
+++ trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp	2021-10-04 05:37:08 UTC (rev 283487)
@@ -53,7 +53,7 @@
 {
 #if USE(GTK4)
     // FIXME: We need a way to override accessible interface of WebView and send the atspi reference to the web process.
-    RELEASE_ASSERT_NOT_REACHED();
+    ASSERT_NOT_IMPLEMENTED_YET();
 #else
     auto* accessible = gtk_widget_get_accessible(viewWidget());
     atk_socket_embed(ATK_SOCKET(accessible), const_cast<char*>(plugID.utf8().data()));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to