Title: [283507] trunk/Source/WebKit
- Revision
- 283507
- Author
- timothy_hor...@apple.com
- Date
- 2021-10-04 12:31:20 -0700 (Mon, 04 Oct 2021)
Log Message
process-entitlements should fail if a subcommand fails
https://bugs.webkit.org/show_bug.cgi?id=231155
Reviewed by Anders Carlsson.
* Scripts/process-entitlements.sh:
See bug 231154, which fixes a mistake in r283156 which made one of the
PlistBuddy invocations from process-entitlements fail, but did not
result in a failing build. PlistBuddy does correctly return a non-zero
return value in this case, so we should just tell the shell to propagate
that upwards.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (283506 => 283507)
--- trunk/Source/WebKit/ChangeLog 2021-10-04 18:31:13 UTC (rev 283506)
+++ trunk/Source/WebKit/ChangeLog 2021-10-04 19:31:20 UTC (rev 283507)
@@ -1,3 +1,17 @@
+2021-10-04 Tim Horton <timothy_hor...@apple.com>
+
+ process-entitlements should fail if a subcommand fails
+ https://bugs.webkit.org/show_bug.cgi?id=231155
+
+ Reviewed by Anders Carlsson.
+
+ * Scripts/process-entitlements.sh:
+ See bug 231154, which fixes a mistake in r283156 which made one of the
+ PlistBuddy invocations from process-entitlements fail, but did not
+ result in a failing build. PlistBuddy does correctly return a non-zero
+ return value in this case, so we should just tell the shell to propagate
+ that upwards.
+
2021-10-04 Alex Christensen <achristen...@webkit.org>
Enable PCM debug mode per WebsiteDataStore instead of process-global
Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (283506 => 283507)
--- trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-10-04 18:31:13 UTC (rev 283506)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-10-04 19:31:20 UTC (rev 283507)
@@ -1,4 +1,5 @@
#!/bin/bash
+set -e
function plistbuddy()
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
