Title: [106635] trunk
- Revision
- 106635
- Author
- [email protected]
- Date
- 2012-02-03 00:16:33 -0800 (Fri, 03 Feb 2012)
Log Message
Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612
Patch by Shinya Kawanaka <[email protected]> on 2012-02-03
Reviewed by Hajime Morita.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().
As a first step, this patch removes ensureShadowRoot() in Internals.
No new tests, because no changes in behavior.
* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
Source/WebKit2:
Exports symbols.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
Modified Paths
Diff
Modified: trunk/ChangeLog (106634 => 106635)
--- trunk/ChangeLog 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/ChangeLog 2012-02-03 08:16:33 UTC (rev 106635)
@@ -1,3 +1,12 @@
+2012-02-03 Shinya Kawanaka <[email protected]>
+
+ Stop calling Element::ensureShadowRoot in Internals.
+ https://bugs.webkit.org/show_bug.cgi?id=77612
+
+ Reviewed by Hajime Morita.
+
+ * Source/autotools/symbols.filter:
+
2012-02-02 Mark Rowe <[email protected]>
<http://webkit.org/b/77717> Makefile should provide control over output verbosity
Modified: trunk/Source/WebCore/ChangeLog (106634 => 106635)
--- trunk/Source/WebCore/ChangeLog 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebCore/ChangeLog 2012-02-03 08:16:33 UTC (rev 106635)
@@ -1,3 +1,22 @@
+2012-02-03 Shinya Kawanaka <[email protected]>
+
+ Stop calling Element::ensureShadowRoot in Internals.
+ https://bugs.webkit.org/show_bug.cgi?id=77612
+
+ Reviewed by Hajime Morita.
+
+ We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
+ But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
+ is built-in or user generated, so let's remove Element::ensureShadowRoot().
+
+ As a first step, this patch removes ensureShadowRoot() in Internals.
+
+ No new tests, because no changes in behavior.
+
+ * WebCore.exp.in:
+ * testing/Internals.cpp:
+ (WebCore::Internals::ensureShadowRoot):
+
2012-02-02 Alexei Filippov <[email protected]>
Web Inspector: Always show percents together with counters in heap inspector.
Modified: trunk/Source/WebCore/WebCore.exp.in (106634 => 106635)
--- trunk/Source/WebCore/WebCore.exp.in 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebCore/WebCore.exp.in 2012-02-03 08:16:33 UTC (rev 106635)
@@ -149,6 +149,7 @@
__ZN7WebCore10ScrollView23setScrollbarsSuppressedEbb
__ZN7WebCore10ScrollView24windowResizerRectChangedEv
__ZN7WebCore10ScrollView8addChildEN3WTF10PassRefPtrINS_6WidgetEEE
+__ZN7WebCore10ShadowRoot6createEPNS_7ElementERi
__ZN7WebCore10deleteFileERKN3WTF6StringE
__ZN7WebCore10handCursorEv
__ZN7WebCore10setCookiesEPNS_8DocumentERKNS_4KURLERKN3WTF6StringE
Modified: trunk/Source/WebCore/testing/Internals.cpp (106634 => 106635)
--- trunk/Source/WebCore/testing/Internals.cpp 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebCore/testing/Internals.cpp 2012-02-03 08:16:33 UTC (rev 106635)
@@ -193,7 +193,10 @@
return 0;
}
- return host->ensureShadowRoot();
+ if (ShadowRoot* root = host->shadowRoot())
+ return root;
+
+ return ShadowRoot::create(host, ec).get();
}
Internals::ShadowRootIfShadowDOMEnabledOrNode* Internals::shadowRoot(Element* host, ExceptionCode& ec)
Modified: trunk/Source/WebKit2/ChangeLog (106634 => 106635)
--- trunk/Source/WebKit2/ChangeLog 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-03 08:16:33 UTC (rev 106635)
@@ -1,3 +1,15 @@
+2012-02-03 Shinya Kawanaka <[email protected]>
+
+ Stop calling Element::ensureShadowRoot in Internals.
+ https://bugs.webkit.org/show_bug.cgi?id=77612
+
+ Reviewed by Hajime Morita.
+
+ Exports symbols.
+
+ * win/WebKit2.def:
+ * win/WebKit2CFLite.def:
+
2012-02-02 Sheriff Bot <[email protected]>
Unreviewed, rolling out r106620.
Modified: trunk/Source/WebKit2/win/WebKit2.def (106634 => 106635)
--- trunk/Source/WebKit2/win/WebKit2.def 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebKit2/win/WebKit2.def 2012-02-03 08:16:33 UTC (rev 106635)
@@ -152,6 +152,7 @@
?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z
?create@HTMLContentElement@WebCore@@SA?AV?$PassRefPtr@VHTMLContentElement@WebCore@@@WTF@@PAVDocument@2@@Z
?create@Range@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@V?$PassRefPtr@VDocument@WebCore@@@4@V?$PassRefPtr@VNode@WebCore@@@4@H1H@Z
+ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z
?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z
?ensureShadowRoot@Element@WebCore@@QAEPAVShadowRoot@2@XZ
?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z
Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (106634 => 106635)
--- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-02-03 08:16:33 UTC (rev 106635)
@@ -146,6 +146,7 @@
?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z
?create@HTMLContentElement@WebCore@@SA?AV?$PassRefPtr@VHTMLContentElement@WebCore@@@WTF@@PAVDocument@2@@Z
?create@Range@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@V?$PassRefPtr@VDocument@WebCore@@@4@V?$PassRefPtr@VNode@WebCore@@@4@H1H@Z
+ ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z
?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z
?ensureShadowRoot@Element@WebCore@@QAEPAVShadowRoot@2@XZ
?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z
Modified: trunk/Source/autotools/symbols.filter (106634 => 106635)
--- trunk/Source/autotools/symbols.filter 2012-02-03 07:44:38 UTC (rev 106634)
+++ trunk/Source/autotools/symbols.filter 2012-02-03 08:16:33 UTC (rev 106635)
@@ -40,6 +40,7 @@
_ZN7WebCore10toDocumentEN3JSC7JSValueE;
_ZN7WebCore10ClientRectC1Ev;
_ZN7WebCore10ClientRectC1ERKNS_7IntRectE;
+_ZN7WebCore10ShadowRoot6createEPNS_7ElementERi;
_ZN7WebCore11EventTarget17toGeneratedStreamEv;
_ZN7WebCore11EventTarget8toStreamEv;
_ZN7WebCore12TextIterator26rangeFromLocationAndLengthEPNS_7ElementEiib;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
