Title: [283542] trunk/LayoutTests
- Revision
- 283542
- Author
- [email protected]
- Date
- 2021-10-05 01:36:43 -0700 (Tue, 05 Oct 2021)
Log Message
Remove unnecessary autofocus attribute dependencies in tests
https://bugs.webkit.org/show_bug.cgi?id=231219
Reviewed by Antti Koivisto.
The new autofocus behaviour timing happens asynchronously with the page "update rendering" steps.
Some tests are using it solely to focus synchronously on elements. We should just use HTMLElement.focus()
there so they don't rely on the current synchronous timing of autofocus.
* fast/forms/number/number-placeholder-with-unacceptable-value-expected.html:
* fast/forms/number/number-placeholder-with-unacceptable-value.html:
* fast/forms/range/range-type-change-onchange.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (283541 => 283542)
--- trunk/LayoutTests/ChangeLog 2021-10-05 07:20:25 UTC (rev 283541)
+++ trunk/LayoutTests/ChangeLog 2021-10-05 08:36:43 UTC (rev 283542)
@@ -1,3 +1,19 @@
+2021-10-05 Tim Nguyen <[email protected]>
+
+ Remove unnecessary autofocus attribute dependencies in tests
+ https://bugs.webkit.org/show_bug.cgi?id=231219
+
+ Reviewed by Antti Koivisto.
+
+ The new autofocus behaviour timing happens asynchronously with the page "update rendering" steps.
+
+ Some tests are using it solely to focus synchronously on elements. We should just use HTMLElement.focus()
+ there so they don't rely on the current synchronous timing of autofocus.
+
+ * fast/forms/number/number-placeholder-with-unacceptable-value-expected.html:
+ * fast/forms/number/number-placeholder-with-unacceptable-value.html:
+ * fast/forms/range/range-type-change-onchange.html:
+
2021-10-04 Tim Nguyen <[email protected]>
Update ios-wk2 test expectations for select-validity.html WPT
Modified: trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value-expected.html (283541 => 283542)
--- trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value-expected.html 2021-10-05 07:20:25 UTC (rev 283541)
+++ trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value-expected.html 2021-10-05 08:36:43 UTC (rev 283542)
@@ -1,4 +1,5 @@
-<input type="number" autofocus>
+<input type="number">
<script>
+document.querySelector('input').focus();
document.execCommand('inserttext', false, 'aaa');
</script>
Modified: trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value.html (283541 => 283542)
--- trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value.html 2021-10-05 07:20:25 UTC (rev 283541)
+++ trunk/LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value.html 2021-10-05 08:36:43 UTC (rev 283542)
@@ -1,4 +1,5 @@
-<input type="number" placeholder="placeholder" autofocus>
+<input type="number" placeholder="placeholder">
<script>
+document.querySelector('input').focus();
document.execCommand('inserttext', false, 'aaa');
</script>
Modified: trunk/LayoutTests/fast/forms/range/range-type-change-onchange.html (283541 => 283542)
--- trunk/LayoutTests/fast/forms/range/range-type-change-onchange.html 2021-10-05 07:20:25 UTC (rev 283541)
+++ trunk/LayoutTests/fast/forms/range/range-type-change-onchange.html 2021-10-05 08:36:43 UTC (rev 283542)
@@ -2,7 +2,7 @@
<body>
<script src=""
-<input id="range1" type="range" _onchange_="updateType(this)" autofocus>
+<input id="range1" type="range" _onchange_="updateType(this)">
<script>
description('Check if no problem happens by type change in onchange handler.');
@@ -17,6 +17,7 @@
}
jsTestIsAsync = true;
+range1.focus();
eventSender.keyDown('upArrow');
</script>
<script src=""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
