Title: [106639] trunk/Source/WebCore
Revision
106639
Author
[email protected]
Date
2012-02-03 01:54:53 -0800 (Fri, 03 Feb 2012)

Log Message

Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (106638 => 106639)


--- trunk/Source/WebCore/ChangeLog	2012-02-03 09:28:00 UTC (rev 106638)
+++ trunk/Source/WebCore/ChangeLog	2012-02-03 09:54:53 UTC (rev 106639)
@@ -1,3 +1,24 @@
+2012-02-03  Kentaro Hara  <[email protected]>
+
+        Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
+        https://bugs.webkit.org/show_bug.cgi?id=77706
+
+        Reviewed by Adam Barth.
+
+        This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
+        and renames [LegacyParent] to [JSLegacyParent].
+
+        No tests. No changes in behavior.
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (Generate):
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GetParentClassName):
+        (GenerateHeader):
+        (GenerateImplementation):
+        * page/DOMWindow.idl:
+        * workers/WorkerContext.idl:
+
 2012-02-03  Pavel Feldman  <[email protected]>
 
         Web Inspector: preserve elements panel selection upon node drag'n'drop

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (106638 => 106639)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2012-02-03 09:28:00 UTC (rev 106638)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2012-02-03 09:54:53 UTC (rev 106639)
@@ -1231,9 +1231,6 @@
 sub Generate {
     my ($object, $dataNode) = @_;
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
-    my $hasRealParent = @{$dataNode->parents} > 0;
-    my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);
     my $parentGObjType = GetParentGObjType($dataNode);
     my $interfaceName = $dataNode->name;

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (106638 => 106639)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-03 09:28:00 UTC (rev 106638)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-03 09:54:53 UTC (rev 106639)
@@ -184,7 +184,7 @@
 {
     my $dataNode = shift;
 
-    return $dataNode->extendedAttributes->{"LegacyParent"} if $dataNode->extendedAttributes->{"LegacyParent"};
+    return $dataNode->extendedAttributes->{"JSLegacyParent"} if $dataNode->extendedAttributes->{"JSLegacyParent"};
     return "JSDOMWrapper" if (@{$dataNode->parents} eq 0);
     return "JS" . $codeGenerator->StripModule($dataNode->parents(0));
 }
@@ -652,7 +652,7 @@
         $codeGenerator->AddMethodsConstantsAndAttributesFromParentClasses($dataNode, \@ancestorInterfaceNames);
     }
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+    my $hasLegacyParent = $dataNode->extendedAttributes->{"JSLegacyParent"};
     my $hasRealParent = @{$dataNode->parents} > 0;
     my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);
@@ -1323,7 +1323,7 @@
     my $className = "JS$interfaceName";
     my $implClassName = $interfaceName;
 
-    my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
+    my $hasLegacyParent = $dataNode->extendedAttributes->{"JSLegacyParent"};
     my $hasRealParent = @{$dataNode->parents} > 0;
     my $hasParent = $hasLegacyParent || $hasRealParent;
     my $parentClassName = GetParentClassName($dataNode);

Modified: trunk/Source/WebCore/page/DOMWindow.idl (106638 => 106639)


--- trunk/Source/WebCore/page/DOMWindow.idl	2012-02-03 09:28:00 UTC (rev 106638)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2012-02-03 09:54:53 UTC (rev 106639)
@@ -40,7 +40,7 @@
         ExtendsDOMGlobalObject,
         GenerateNativeConverter,
         ReplaceableConstructor,
-        LegacyParent=JSDOMWindowBase
+        JSLegacyParent=JSDOMWindowBase
     ] DOMWindow {
         // DOM Level 0
         attribute [Replaceable] Screen screen;

Modified: trunk/Source/WebCore/workers/WorkerContext.idl (106638 => 106639)


--- trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-03 09:28:00 UTC (rev 106638)
+++ trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-03 09:54:53 UTC (rev 106639)
@@ -33,7 +33,7 @@
         EventTarget,
         ExtendsDOMGlobalObject,
         IsWorkerContext,
-        LegacyParent=JSWorkerContextBase,
+        JSLegacyParent=JSWorkerContextBase,
         NoStaticTables,
         OmitConstructor
     ] WorkerContext {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to