Title: [283604] trunk/Source/WebKit
- Revision
- 283604
- Author
- [email protected]
- Date
- 2021-10-06 00:34:37 -0700 (Wed, 06 Oct 2021)
Log Message
Close NetworkRTCProvider sockets explicitly when closing NetworkRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=231228
<rdar://83237496>
Reviewed by Eric Carlson.
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::close):
Make sure to explictly closing the socket before deleting it.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (283603 => 283604)
--- trunk/Source/WebKit/ChangeLog 2021-10-06 07:15:38 UTC (rev 283603)
+++ trunk/Source/WebKit/ChangeLog 2021-10-06 07:34:37 UTC (rev 283604)
@@ -1,3 +1,15 @@
+2021-10-06 Youenn Fablet <[email protected]>
+
+ Close NetworkRTCProvider sockets explicitly when closing NetworkRTCProvider
+ https://bugs.webkit.org/show_bug.cgi?id=231228
+ <rdar://83237496>
+
+ Reviewed by Eric Carlson.
+
+ * NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+ (WebKit::NetworkRTCProvider::close):
+ Make sure to explictly closing the socket before deleting it.
+
2021-10-05 Alex Christensen <[email protected]>
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp (283603 => 283604)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2021-10-06 07:15:38 UTC (rev 283603)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2021-10-06 07:34:37 UTC (rev 283604)
@@ -126,7 +126,10 @@
m_rtcMonitor.stopUpdating();
callOnRTCNetworkThread([this]() {
- m_sockets.clear();
+ auto sockets = WTFMove(m_sockets);
+ for (auto& socket : m_sockets.values())
+ socket->close();
+ ASSERT(sockets.isEmpty());
#if PLATFORM(COCOA)
m_attributedBundleIdentifiers.clear();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
