Title: [283628] trunk/Source/WebCore
- Revision
- 283628
- Author
- [email protected]
- Date
- 2021-10-06 09:56:44 -0700 (Wed, 06 Oct 2021)
Log Message
CoreAudioSharedUnit should not clear its persistentID when device capture changes
https://bugs.webkit.org/show_bug.cgi?id=231280
Reviewed by Eric Carlson.
Manually tested.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::cleanupAudioUnit):
Partially reverting https://commits.webkit.org/r280702 which was clearing m_persistentID in cleanUpAudioUnit.
The issue is that when unit is capturing and is changing capturing device, it will set m_persistentID then cleanUpAudioUnit
as part of its reconfiguration. This was making m_persistentID being empty.
When starting to capture, we often receive a notification of changed devices and we would check whether the new devices set
contains m_persistentID. If not (which is the case since m_persistentID is empty), we would fail the capture.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283627 => 283628)
--- trunk/Source/WebCore/ChangeLog 2021-10-06 16:30:57 UTC (rev 283627)
+++ trunk/Source/WebCore/ChangeLog 2021-10-06 16:56:44 UTC (rev 283628)
@@ -1,3 +1,20 @@
+2021-10-06 Youenn Fablet <[email protected]>
+
+ CoreAudioSharedUnit should not clear its persistentID when device capture changes
+ https://bugs.webkit.org/show_bug.cgi?id=231280
+
+ Reviewed by Eric Carlson.
+
+ Manually tested.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+ (WebCore::CoreAudioSharedUnit::cleanupAudioUnit):
+ Partially reverting https://commits.webkit.org/r280702 which was clearing m_persistentID in cleanUpAudioUnit.
+ The issue is that when unit is capturing and is changing capturing device, it will set m_persistentID then cleanUpAudioUnit
+ as part of its reconfiguration. This was making m_persistentID being empty.
+ When starting to capture, we often receive a notification of changed devices and we would check whether the new devices set
+ contains m_persistentID. If not (which is the case since m_persistentID is empty), we would fail the capture.
+
2021-10-06 Chris Lord <[email protected]>
[GTK][WPE] CSS scroll snapping interacts badly with smooth scrolling
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (283627 => 283628)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2021-10-06 16:30:57 UTC (rev 283627)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2021-10-06 16:56:44 UTC (rev 283628)
@@ -471,7 +471,6 @@
m_microphoneSampleBuffer = nullptr;
m_speakerSampleBuffer = nullptr;
- m_persistentID = emptyString();
#if !LOG_DISABLED
m_ioUnitName = emptyString();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
