Title: [283647] trunk/Tools
- Revision
- 283647
- Author
- [email protected]
- Date
- 2021-10-06 12:52:49 -0700 (Wed, 06 Oct 2021)
Log Message
[ iOS15 Release ] TestWebKitAPI.WebSocket.CloseCode
https://bugs.webkit.org/show_bug.cgi?id=231306
Patch by Alex Christensen <[email protected]> on 2021-10-06
Reviewed by Chris Dumez.
This test starts by navigating, opening a websocket connection, then navigating away.
Sometimes in release builds we only get one didFinishNavigation callback.
The important thing about this test is that the server receives the expected close code
whenever the page is navigated away from, so drop the two didFinishNavigation checks.
I manually verified that on iOS15 simulator release builds the test would time out here,
and that it doesn't any more.
* TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (283646 => 283647)
--- trunk/Tools/ChangeLog 2021-10-06 19:32:04 UTC (rev 283646)
+++ trunk/Tools/ChangeLog 2021-10-06 19:52:49 UTC (rev 283647)
@@ -1,3 +1,21 @@
+2021-10-06 Alex Christensen <[email protected]>
+
+ [ iOS15 Release ] TestWebKitAPI.WebSocket.CloseCode
+ https://bugs.webkit.org/show_bug.cgi?id=231306
+
+ Reviewed by Chris Dumez.
+
+ This test starts by navigating, opening a websocket connection, then navigating away.
+ Sometimes in release builds we only get one didFinishNavigation callback.
+ The important thing about this test is that the server receives the expected close code
+ whenever the page is navigated away from, so drop the two didFinishNavigation checks.
+
+ I manually verified that on iOS15 simulator release builds the test would time out here,
+ and that it doesn't any more.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm:
+ (TestWebKitAPI::TEST):
+
2021-10-06 Philip Chimento <[email protected]>
Style checker should check spacing inside braces with elements in them
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm (283646 => 283647)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm 2021-10-06 19:32:04 UTC (rev 283646)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm 2021-10-06 19:52:49 UTC (rev 283647)
@@ -181,8 +181,6 @@
auto webView = adoptNS([WKWebView new]);
[webView loadRequest:httpServer.request("/navigateAway")];
- [webView _test_waitForDidFinishNavigation];
- [webView _test_waitForDidFinishNavigation];
Util::run(&receivedWebSocketClose);
Vector<uint8_t> expected { 0x3, 0xe9 }; // NSURLSessionWebSocketCloseCodeGoingAway
appendString(expected, "WebSocket is closed due to suspension.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
