Title: [283672] trunk/Source/WebCore
- Revision
- 283672
- Author
- [email protected]
- Date
- 2021-10-06 15:26:48 -0700 (Wed, 06 Oct 2021)
Log Message
Unreviewed, reverting r283634.
https://bugs.webkit.org/show_bug.cgi?id=231332
Some debug assertions. RenderLayer needs to be fixed first
Reverted changeset:
"Ensure that the top layer is always anchored to the
RenderView"
https://bugs.webkit.org/show_bug.cgi?id=231292
https://commits.webkit.org/r283634
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283671 => 283672)
--- trunk/Source/WebCore/ChangeLog 2021-10-06 22:12:54 UTC (rev 283671)
+++ trunk/Source/WebCore/ChangeLog 2021-10-06 22:26:48 UTC (rev 283672)
@@ -1,3 +1,17 @@
+2021-10-06 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r283634.
+ https://bugs.webkit.org/show_bug.cgi?id=231332
+
+ Some debug assertions. RenderLayer needs to be fixed first
+
+ Reverted changeset:
+
+ "Ensure that the top layer is always anchored to the
+ RenderView"
+ https://bugs.webkit.org/show_bug.cgi?id=231292
+ https://commits.webkit.org/r283634
+
2021-10-06 Wenson Hsieh <[email protected]>
Move FlushIdentifier out of the DisplayList namespace
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (283671 => 283672)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2021-10-06 22:12:54 UTC (rev 283671)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2021-10-06 22:26:48 UTC (rev 283672)
@@ -657,9 +657,8 @@
RenderBlock* RenderObject::containingBlock() const
{
- auto containingBlockForRenderer = [](const auto& renderer) -> RenderBlock* {
- if (isInTopLayerOrBackdrop(renderer.style(), renderer.element()))
- return &renderer.view();
+ auto containingBlockForRenderer = [](const RenderElement& renderer)
+ {
if (renderer.isAbsolutelyPositioned())
return renderer.containingBlockForAbsolutePosition();
if (renderer.isFixedPositioned())
@@ -1469,8 +1468,6 @@
// This does mean that computePositionedLogicalWidth and computePositionedLogicalHeight have to use container().
if (!is<RenderElement>(renderer))
return renderer.parent();
- if (isInTopLayerOrBackdrop(renderer.style(), downcast<RenderElement>(renderer).element()))
- return &renderer.view();
auto position = renderer.style().position();
if (position == PositionType::Static || position == PositionType::Relative || position == PositionType::Sticky)
return renderer.parent();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
