[webkit-changes] [283702] trunk/Source/WebKit

Thu, 07 Oct 2021 00:57:17 -0700

Title: [283702] trunk/Source/WebKit
Revision
283702
Author
[email protected]
Date
2021-10-07 00:56:31 -0700 (Thu, 07 Oct 2021)

Log Message

Change the confusing feature name for testing purpose
https://bugs.webkit.org/show_bug.cgi?id=231259

Reviewed by Tim Horton.

ENABLE(EXPERIMENTAL_FEATURE) was used in the test, but that is very confusing with
ENABLE_EXPERIMENTAL_FEATURES. Change them to more obvious ENABLE(FEATURE_FOR_TESTING).

* Scripts/webkit/parser_unittest.py:
* Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::jsValueForArguments):
(IPC::messageArgumentDescriptions):
* Scripts/webkit/tests/MessageNames.cpp:
(IPC::isValidMessageName):
* Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
* Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
* Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
* Scripts/webkit/tests/TestWithoutAttributes.messages.in:
* Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
(WebKit::TestWithoutAttributes::didReceiveMessage):
* Scripts/webkit/tests/TestWithoutAttributesMessages.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (283701 => 283702)


--- trunk/Source/WebKit/ChangeLog	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/ChangeLog	2021-10-07 07:56:31 UTC (rev 283702)
@@ -1,3 +1,28 @@
+2021-10-07  Basuke Suzuki  <[email protected]>
+
+        Change the confusing feature name for testing purpose
+        https://bugs.webkit.org/show_bug.cgi?id=231259
+
+        Reviewed by Tim Horton.
+
+        ENABLE(EXPERIMENTAL_FEATURE) was used in the test, but that is very confusing with
+        ENABLE_EXPERIMENTAL_FEATURES. Change them to more obvious ENABLE(FEATURE_FOR_TESTING).
+
+        * Scripts/webkit/parser_unittest.py:
+        * Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
+        (IPC::jsValueForArguments):
+        (IPC::messageArgumentDescriptions):
+        * Scripts/webkit/tests/MessageNames.cpp:
+        (IPC::isValidMessageName):
+        * Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
+        * Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
+        (WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
+        * Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
+        * Scripts/webkit/tests/TestWithoutAttributes.messages.in:
+        * Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
+        (WebKit::TestWithoutAttributes::didReceiveMessage):
+        * Scripts/webkit/tests/TestWithoutAttributesMessages.h:
+
 2021-10-06  Timothy Hatcher  <[email protected]>
 
         _WKRemoteObjectRegistry's ReplyBlockCallChecker should always dealloc on the main thread

Modified: trunk/Source/WebKit/Scripts/webkit/parser_unittest.py (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/parser_unittest.py	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/parser_unittest.py	2021-10-07 07:56:31 UTC (rev 283702)
@@ -218,7 +218,7 @@
             'parameters': (
                 ('IPC::DummyType', 'dummy'),
             ),
-            'conditions': ('ENABLE(EXPERIMENTAL_FEATURE)'),
+            'conditions': ('ENABLE(FEATURE_FOR_TESTING)'),
         }
     ),
 }

Modified: trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp	2021-10-07 07:56:31 UTC (rev 283702)
@@ -39,7 +39,7 @@
 #if (ENABLE(WEBKIT2) && (NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND))
 #include "ArgumentCoders.h"
 #include "Connection.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FOR_TESTING)
 #include "DummyType.h"
 #endif
 #if PLATFORM(MAC)
@@ -71,7 +71,7 @@
 #if (ENABLE(WEBKIT2) && (NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND))
 #include "ArgumentCoders.h"
 #include "Connection.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FOR_TESTING)
 #include "DummyType.h"
 #endif
 #if PLATFORM(MAC)
@@ -208,7 +208,7 @@
     case MessageName::TestWithLegacyReceiver_DeprecatedOperation:
         return jsValueForDecodedArguments<Messages::TestWithLegacyReceiver::DeprecatedOperation::Arguments>(globalObject, decoder);
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     case MessageName::TestWithLegacyReceiver_ExperimentalOperation:
         return jsValueForDecodedArguments<Messages::TestWithLegacyReceiver::ExperimentalOperation::Arguments>(globalObject, decoder);
 #endif
@@ -268,7 +268,7 @@
     case MessageName::TestWithoutAttributes_DeprecatedOperation:
         return jsValueForDecodedArguments<Messages::TestWithoutAttributes::DeprecatedOperation::Arguments>(globalObject, decoder);
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     case MessageName::TestWithoutAttributes_ExperimentalOperation:
         return jsValueForDecodedArguments<Messages::TestWithoutAttributes::ExperimentalOperation::Arguments>(globalObject, decoder);
 #endif
@@ -483,7 +483,7 @@
             {"dummy", "IPC::DummyType", nullptr, false},
         };
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     case MessageName::TestWithLegacyReceiver_ExperimentalOperation:
         return Vector<ArgumentDescription> {
             {"dummy", "IPC::DummyType", nullptr, false},
@@ -592,7 +592,7 @@
             {"dummy", "IPC::DummyType", nullptr, false},
         };
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     case MessageName::TestWithoutAttributes_ExperimentalOperation:
         return Vector<ArgumentDescription> {
             {"dummy", "IPC::DummyType", nullptr, false},

Modified: trunk/Source/WebKit/Scripts/webkit/tests/MessageNames.cpp (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/MessageNames.cpp	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/MessageNames.cpp	2021-10-07 07:56:31 UTC (rev 283702)
@@ -320,7 +320,7 @@
 #endif
     if (messageName == IPC::MessageName::TestWithLegacyReceiver_DidReceivePolicyDecision)
         return true;
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     if (messageName == IPC::MessageName::TestWithLegacyReceiver_ExperimentalOperation)
         return true;
 #endif
@@ -416,7 +416,7 @@
 #endif
     if (messageName == IPC::MessageName::TestWithoutAttributes_DidReceivePolicyDecision)
         return true;
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     if (messageName == IPC::MessageName::TestWithoutAttributes_ExperimentalOperation)
         return true;
 #endif

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in	2021-10-07 07:56:31 UTC (rev 283702)
@@ -68,7 +68,7 @@
     DeprecatedOperation(IPC::DummyType dummy)
 #endif
 
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     ExperimentalOperation(IPC::DummyType dummy)
 #endif
 }

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp	2021-10-07 07:56:31 UTC (rev 283702)
@@ -29,7 +29,7 @@
 #include "ArgumentCoders.h"
 #include "Connection.h"
 #include "Decoder.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FOR_TESTING)
 #include "DummyType.h"
 #endif
 #if PLATFORM(MAC)
@@ -125,7 +125,7 @@
     if (decoder.messageName() == Messages::TestWithLegacyReceiver::DeprecatedOperation::name())
         return IPC::handleMessage<Messages::TestWithLegacyReceiver::DeprecatedOperation>(connection, decoder, this, &TestWithLegacyReceiver::deprecatedOperation);
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     if (decoder.messageName() == Messages::TestWithLegacyReceiver::ExperimentalOperation::name())
         return IPC::handleMessage<Messages::TestWithLegacyReceiver::ExperimentalOperation>(connection, decoder, this, &TestWithLegacyReceiver::experimentalOperation);
 #endif

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h	2021-10-07 07:56:31 UTC (rev 283702)
@@ -530,7 +530,7 @@
 };
 #endif
 
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
 class ExperimentalOperation {
 public:
     using Arguments = std::tuple<const IPC::DummyType&>;

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in	2021-10-07 07:56:31 UTC (rev 283702)
@@ -75,7 +75,7 @@
     DeprecatedOperation(IPC::DummyType dummy)
 #endif
 
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     ExperimentalOperation(IPC::DummyType dummy)
 #endif
 }

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp	2021-10-07 07:56:31 UTC (rev 283702)
@@ -29,7 +29,7 @@
 #include "ArgumentCoders.h"
 #include "Connection.h"
 #include "Decoder.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FOR_TESTING)
 #include "DummyType.h"
 #endif
 #if PLATFORM(MAC)
@@ -125,7 +125,7 @@
     if (decoder.messageName() == Messages::TestWithoutAttributes::DeprecatedOperation::name())
         return IPC::handleMessage<Messages::TestWithoutAttributes::DeprecatedOperation>(connection, decoder, this, &TestWithoutAttributes::deprecatedOperation);
 #endif
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
     if (decoder.messageName() == Messages::TestWithoutAttributes::ExperimentalOperation::name())
         return IPC::handleMessage<Messages::TestWithoutAttributes::ExperimentalOperation>(connection, decoder, this, &TestWithoutAttributes::experimentalOperation);
 #endif

Modified: trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h (283701 => 283702)


--- trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h	2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h	2021-10-07 07:56:31 UTC (rev 283702)
@@ -530,7 +530,7 @@
 };
 #endif
 
-#if ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(FEATURE_FOR_TESTING)
 class ExperimentalOperation {
 public:
     using Arguments = std::tuple<const IPC::DummyType&>;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to