Title: [283736] trunk
- Revision
- 283736
- Author
- [email protected]
- Date
- 2021-10-07 12:57:03 -0700 (Thu, 07 Oct 2021)
Log Message
Misc compiler warning fixes, October 2021
https://bugs.webkit.org/show_bug.cgi?id=231377
Patch by Michael Catanzaro <[email protected]> on 2021-10-07
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Fix -Wreturn-type warnings.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontPaletteFromStyle):
* css/CSSFontPaletteValuesRule.cpp:
(WebCore::CSSFontPaletteValuesRule::basePalette const):
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::releaseThreadResources):
Tools:
Stop testing the default value of the XSS auditor setting. I could have used
IGNORE_DEPRECATED_DECLARATIONS_BEGIN instead, but I see no point in testing the default
value of a setting that no longer does anything.
* TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (283735 => 283736)
--- trunk/Source/WebCore/ChangeLog 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Source/WebCore/ChangeLog 2021-10-07 19:57:03 UTC (rev 283736)
@@ -1,3 +1,19 @@
+2021-10-07 Michael Catanzaro <[email protected]>
+
+ Misc compiler warning fixes, October 2021
+ https://bugs.webkit.org/show_bug.cgi?id=231377
+
+ Reviewed by Adrian Perez de Castro.
+
+ Fix -Wreturn-type warnings.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::fontPaletteFromStyle):
+ * css/CSSFontPaletteValuesRule.cpp:
+ (WebCore::CSSFontPaletteValuesRule::basePalette const):
+ * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
+ (WebCore::GraphicsContextGLOpenGL::releaseThreadResources):
+
2021-10-07 Chris Dumez <[email protected]>
Add feature flag for COOP / COEP violation reporting and turn off by default
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (283735 => 283736)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2021-10-07 19:57:03 UTC (rev 283736)
@@ -1850,6 +1850,7 @@
case FontPalette::Type::Custom:
return CSSValuePool::singleton().createCustomIdent(fontPalette.identifier);
}
+ RELEASE_ASSERT_NOT_REACHED();
}
Ref<CSSPrimitiveValue> ComputedStyleExtractor::fontNonKeywordWeightFromStyleValue(FontSelectionValue weight)
Modified: trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp (283735 => 283736)
--- trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp 2021-10-07 19:57:03 UTC (rev 283736)
@@ -70,6 +70,7 @@
return m_fontPaletteValuesRule->basePalette().string;
return StringImpl::empty();
}
+ RELEASE_ASSERT_NOT_REACHED();
}
String CSSFontPaletteValuesRule::overrideColors() const
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp (283735 => 283736)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-07 19:57:03 UTC (rev 283736)
@@ -78,6 +78,7 @@
#if !USE(ANGLE)
bool GraphicsContextGLOpenGL::releaseThreadResources(ReleaseThreadResourceBehavior)
{
+ return false;
}
void GraphicsContextGLOpenGL::platformReleaseThreadResources()
Modified: trunk/Tools/ChangeLog (283735 => 283736)
--- trunk/Tools/ChangeLog 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Tools/ChangeLog 2021-10-07 19:57:03 UTC (rev 283736)
@@ -1,3 +1,17 @@
+2021-10-07 Michael Catanzaro <[email protected]>
+
+ Misc compiler warning fixes, October 2021
+ https://bugs.webkit.org/show_bug.cgi?id=231377
+
+ Reviewed by Adrian Perez de Castro.
+
+ Stop testing the default value of the XSS auditor setting. I could have used
+ IGNORE_DEPRECATED_DECLARATIONS_BEGIN instead, but I see no point in testing the default
+ value of a setting that no longer does anything.
+
+ * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
+ (TestWebKitAPI::TEST):
+
2021-10-07 BJ Burg <[email protected]>
Web Inspector: WebInspectorExtensionTabContentView should not reload its iframe when detached
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp (283735 => 283736)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp 2021-10-07 19:48:16 UTC (rev 283735)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp 2021-10-07 19:57:03 UTC (rev 283736)
@@ -79,7 +79,6 @@
EXPECT_TRUE(WKPreferencesGetLoadsImagesAutomatically(preference));
EXPECT_EQ(expectedApplicationCacheEnabled, WKPreferencesGetOfflineWebApplicationCacheEnabled(preference));
EXPECT_TRUE(WKPreferencesGetLocalStorageEnabled(preference));
- EXPECT_FALSE(WKPreferencesGetXSSAuditorEnabled(preference));
EXPECT_FALSE(WKPreferencesGetFrameFlatteningEnabled(preference));
EXPECT_TRUE(WKPreferencesGetPluginsEnabled(preference));
EXPECT_TRUE(WKPreferencesGetJavaEnabled(preference));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
